240936 - --disable-profilelocking option does not work

Status: RESOLVED FIXED

(Core Graveyard :: Profile: BackEnd, defect)

Description

[wind li]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.6) Gecko/20040113

nsProfile.cpp ignore this option

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[wind li]

Attachment: add --disable-profilelocking support to nsProfile.cpp

if --disable-profilelocking  is not setted then
will not be defined MOZ_PROFILELOCKING

Comment 2

[wind li]

I am working for OOo, we use Mozilla components to access addressbooks in OOo in
nearly readonly mode.
See http://dba.openoffice.org and
http://qa.openoffice.org/issues/show_bug.cgi?id=11424 for detail.
So we need build a Mozilla without profile locking function. I found that there
is a config option --disable-profilelocking. But it does not work. So I make
this patch.

Comment 3

[Brendan Eich [:brendan]]

Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

I'm not a module owner or peer for profile.  Wind, please follow the rules in
http://www.mozilla.org/hacking/.

/be

Comment 4

[timeless]

Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

+ #endif
 ^ errant whitespace

Comment 5

[wind li]

Attachment: remove the space

:)

Comment 6

[Conrad Carlen (not reading bugmail)]

Comment on attachment 146482 [details] [diff] [review]
remove the space

r=ccarlen.

I think somebody added --disable-profilelocking to support only the
--enable-single-profile config (where there is no profile mgr) for minimo. This
makes it work in any case.

Comment 7

[wind li]

ccarlen
Can you please suggest a superreviewer?
Thanks

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 146479 [details] [diff] [review]
add --disable-profilelocking support to nsProfile.cpp

removing obsolete review req.

Comment 9

[Kyle Yuan]

fixed.