241061 - Action name exported by mozilla is messed up in at-poke

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Louie Zhao]

Using at-poke to examine "action" of mozilla's element, the actoin name is
messed up. This bug is caused by wrong cache of name string. Meanwhile, the
current implementation will export the same action name for all actions of the
element.

Comment 1

[Louie Zhao]

Attachment: patch v1

Comment 2

[Philip K. Warren]

Comment on attachment 146568 [details] [diff] [review]
patch v1

Looks good.

Comment 3

[Henry Jia]

Comment on attachment 146568 [details] [diff] [review]
patch v1

sr=henry

Comment 4

[Louie Zhao]

Thanks for r and sr. Patch checked in trunk.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

+    void SetName(nsAString &aString) { mName = NS_ConvertUCS2toUTF8(aString); }

CopyUTF16toUTF8(aString, mName) would have been better...

Comment 6

[Aaron Leventhal]

Biesi, can you tell us more about why that's better? We use it in several places.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

it avoids one string copy. NS_ConvertUCS... itself converts the string; and then
the assignment copies again.

CopyUTF8To... just copies once.

also see bug 209699 comment 0

(this is of course only an issue when assigning an NS_Convert... to something else)