Closed
Bug 241130
Opened 20 years ago
Closed 20 years ago
si_CheckGetUsernamePassword does work to get a better dialog title and then does nothing with it
Categories
(SeaMonkey :: Passwords & Permissions, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(1 file)
|
1.70 KB,
patch
|
mvl
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
static nsresult
si_CheckGetUsernamePassword
(PRUnichar ** username,
...
const PRUnichar* dialogTitle,
...
PRBool* checkValue)
{
...
PRUnichar * prompt_string = (PRUnichar*)dialogTitle;
if (dialogTitle == nsnull || dialogTitle[0] == 0)
prompt_string = Wallet_Localize("PromptForPassword");
...
res = dialog->PromptUsernameAndPassword(dialogTitle,
...
&confirmed);
if (dialogTitle == nsnull || dialogTitle[0] == 0)
Recycle(prompt_string);
...
}
encountered when i accidentally ran a build which had password manager instead
of my normal builds which don't.
(I'm replacing the prompt service and it seems I don't tolerate null very well).
Attachment #146746 -
Flags: review?(mvl)
Attachment #146746 -
Flags: superreview?(dveditz)
|
||
Updated•20 years ago
|
Attachment #146746 -
Flags: review?(mvl) → review+
|
||
Comment 2•20 years ago
|
||
Comment on attachment 146746 [details] [diff] [review] use the variable sr=dveditz
Attachment #146746 -
Flags: superreview?(dveditz) → superreview+
mozilla/extensions/wallet/src/singsign.cpp 1.240
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•