241147 - DecodeStructParticle fails on 'sequences' and 'choices'

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect, P1)

Description

[Darin Fisher]

DecodeStructParticle fails on 'sequences' and 'choices'

This prevents writing a webservice that returns a struct type.

The patch is a one-line update-the-iterator fix! :-/

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Darin Fisher]

This is blocking the Firefox 0.9 extension manager.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 146641 [details] [diff] [review]
v1 patch

r=[e-mail]

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 146641 [details] [diff] [review]
v1 patch

-	     rc = DecodeStructParticle(aEncoding, aElement, child,
aAttachments, aDestination, getter_AddRefs(after));
+	     rc = DecodeStructParticle(aEncoding, next, child, aAttachments,
aDestination, getter_AddRefs(after));

Nice :)

	     if (!NS_FAILED(rc)) {

Wanna change that to NS_SUCCEEDED(rc) while you're here (there's more than one
tho...)?

sr=jst

Comment 5

[Darin Fisher]

i'll cleanup the "!NS_FAILED" junk in another patch... i want to keep this one
simple since it needs to land for 1.7 as well.

Comment 6

[Darin Fisher]

fixed-on-trunk for 1.8 alpha

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 146641 [details] [diff] [review]
v1 patch

a=asa (on behalf of drivers) for checkin to 1.7

Comment 8

[Darin Fisher]

fixed1.7