241151 - Get rid of nsSpringFrame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[[e-mail]]

In release builds, nsSpringFrame overrides one method on nsLeafBoxFrame. The
code for that method matches that on nsLeafBoxFrame.
In debug builds, nsSpringFrame overrides a second method on nsLeafBoxFrame
although that method is never called, as NS_NewLeafBoxFrame is not used.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

nsLeafBoxFrame is the base class for a bunch of other frame classes as well.  If
you want to remove one it should be nsSpringFrame.

That said, GetFrameName is virtual and is used in debugging code, but probably
not all that important.

Comment 2

[[e-mail]]

Attachment: Proposed patch

The GetFrameName issue is just that anybody who uses it needs to know that
<xul:spacer> now returns LeafBoxFrame instead of SpringFrame.

Comment 3

[[e-mail]]

Attachment: Forgot to diff Makefile.in

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 146683 [details] [diff] [review]
Forgot to diff Makefile.in

if only all reviews were this easy.

Comment 5

[[e-mail]]

Fix checked in.