Closed
Bug 241200
Opened 21 years ago
Closed 21 years ago
It should not be an error for a @mozilla.org/pref-relativefile;1 to not have a file
Categories
(Core :: Preferences: Backend, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
Details
Attachments
(2 files)
|
715 bytes,
text/plain
|
Details | |
|
717 bytes,
patch
|
caillon
:
review+
dveditz
:
superreview+
|
Details | Diff | Splinter Review |
Attachment #146679 -
Flags: superreview?(dveditz)
Attachment #146679 -
Flags: review?(caillon)
Attachment #146680 -
Flags: superreview?(dveditz)
Attachment #146680 -
Flags: review?(caillon)
Attachment #146679 -
Flags: superreview?(dveditz)
Attachment #146679 -
Flags: review?(caillon)
|
||
Comment 3•21 years ago
|
||
Comment on attachment 146679 [details]
testcase
>pr=Components.classes["@mozilla.org/pref-relativefile;1"].createInstance(Components.interfaces.nsIRelativeFilePref);
>pr.file
Sure this triggers the "bug", but how is this a valid use case? It seems to me
that using something which hasn't yet been initialized is indeed an error.
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 146680 [details] [diff] [review]
return ok
Ok timeless convinced me on IRC. r=caillon
Attachment #146680 -
Flags: review?(caillon) → review+
|
||
Comment 5•21 years ago
|
||
Comment on attachment 146680 [details] [diff] [review]
return ok
sr=dveditz
Attachment #146680 -
Flags: superreview?(dveditz) → superreview+
Attachment #146679 -
Attachment is patch: false
mozilla/modules/libpref/src/nsPrefBranch.cpp 1.56
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•