241214 - Trap while clicking on CLOSE button of Print Preview.

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Sachin]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040325
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040325

Open www.amazon.com in the browser. Launch the Print Preview window when the
page is completely loaded. Clicking on the CLOSE button of Print Preview results
in trap and abnormal termination of the browser.

Reproducible: Always
Steps to Reproduce:
1. Open www.amazon.com in the browser.
2. Open Print Preview window
3. Click on the "CLOSE" button to close the Print Preview window.
Actual Results:  
The browser traps with abnormal termination.

Expected Results:  
Print Preview window gets closed.

Trap screen Info:

04-21-2004  19:49:44  SYS3186  PID 00c0  TID 0001  Slot 0042
F:\MOZILLA\17B\MOZILLA.EXE
c000009d
00290158
EAX=011bfbf8  EBX=012289c0  ECX=011f9340  EDX=011f9340
ESI=012289c0  EDI=01228960  
DS=0053  DSACC=d0f3  DSLIM=3fffffff  
ES=0053  ESACC=d0f3  ESLIM=3fffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:00290158  CSACC=d0df  CSLIM=3fffffff
SS:ESP=0053:0012d964  SSACC=d0f3  SSLIM=3fffffff
EBP=0012d980  FLG=00012216

LIBC05.DLL

Comment 1

[Sachin]

I have debugged this problem. The problem is in routine GetParent() which is in
nsWindow.cpp file. The trap occurs while accesing mParent(line #1128), as the
Parent window is in the state of destruction.  

In GetParent() routine, the IF condition shown below,  tagged with "241214"
solves the problem. However I will refine the changes and upload the patch soon.


1126    if( nsnull != mParent)
1127    {
          if(mParent->mIsDestroying)   //241214
            return nsnull;             //241214    

1128       NS_ADDREF(mParent);
1129       widget = mParent;
1130    }

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

Add support for mOnDestroyCalled

Fix a few other bugs as well - initialize mIsDestroying

remove unused variable - mHackDestroyWnd

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 146695 [details] [diff] [review]
Fix for problem

sr=blizzard (platform specific)
a=mkaply (OS/2 only)

Comment 4

[Mike Kaply [:mkaply]]

Fix checked in.