241237 - getRegistryEntry returns NS_ERROR_OUT_OF_MEMORY when key not found

Status: RESOLVED INVALID

(Firefox :: Shell Integration, defect)

Description

[Henrik Gemal]

when you try to open a nonexisting registry key with getRegistryEntry()
you get:

launchy: Unable to find Mozilla Firebird due to [Exception... "Component
returned failure code: 0x8007000e (NS_ERROR_OUT_OF_MEMORY)
[nsIWindowsShellService.getRegistryEntry]"  nsresult: "0x8007000e
(NS_ERROR_OUT_OF_MEMORY)"  location: "JS frame ::
chrome://launchy/content/context.js :: anonymous :: line 47"  data: no]

isn't "NS_ERROR_OUT_OF_MEMORY" wrong?

Isn't it correct to just return NS_OK since the operation went OK but the
registry entry just wasn't there?

Comment 1

[Boris Zbarsky [:bzbarsky]]

On another note, is this limiting to 4096 bytes on purpose?  See
http://lxr.mozilla.org/seamonkey/source/uriloader/exthandler/win/nsOSHelperAppService.cpp#150
for code that can handle arbitrary lengths by asking for the length first...
(though it's sorta lacking in error checking).

Comment 2

[Jesse Ruderman]

I was also confused when I got NS_ERROR_OUT_OF_MEMORY.  My code was similar to:

var winShell = Components.
                 classes["@mozilla.org/browser/shell-service;1"].
                   getService(Components.interfaces.nsIWindowsShellService);

alert(winShell.getRegistryEntry(
  Components.interfaces.nsIWindowsShellService.HKCU,
  "Software",
  "foo"
));

Comment 3

[(not currently active) Ted Mielczarek]

Probably invalid since bug 292981 landed.  Or maybe WFM.  I dunno.