241288 - installer and browser files not stripped in installer build

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Andrew Schultz]

today's linux build from the 1.7 branch
(mozilla-i686-pc-linux-gnu-1.7rc1-installer.tar.gz) is 15467852 bytes

today's nightly build from the trunk
(mozilla-i686-pc-linux-gnu-full-installer.tar.gz) is 12677202 bytes

part of the difference is talkback, which accounts for 800KB on the branch and
is still missing on the trunk.  negotiate-auth and tasks extensions are built on
trunk and not on the branch.

The big difference is that the files that go into browser.xpi are not being
stripped (browser.xpi itself is ~1MB larger on the branch than the trunk). 
Files going into other .xpi (such as mail.xpi) are being stripped properly.

The rest is from the installer itself (mozilla-installer-bin), which is not
being stripped on the branch.  The stub installer does seem to be stripped as
the files on the ftp site are similar in size.

Comment 1

[Andrew Schultz]

with the addition of talkback on the trunk, (bug 218898), trunk files are now
not stripped as well.

Comment 2

[Daniel (Leaf) Nunes]

I can't imagine why the browser files would cease being stripped because of
talkback; the installer binary issue i am aware of, as well as the 800K of the
talkback utility itself. I will investigate.

Comment 3

[Daniel (Leaf) Nunes]

argh. There's code in makexpi.pl to strip "libraries" before zipping the xpi;
unfortunately it only strips .so files, ignoring the other binaries with
debugging symbols. I'll come up with a patch presently.

Comment 4

[Daniel (Leaf) Nunes]

Attachment: don't just strip .so files; run strip on all files, since it ignores files that don't have recognizable debugging symbols

Comment 5

[Daniel (Leaf) Nunes]

Comment on attachment 147033 [details] [diff] [review]
don't just strip .so files; run strip on all files, since it ignores files that don't have recognizable debugging symbols

seeking review.

Comment 6

[Daniel (Leaf) Nunes]

checked into trunk, seeking approval for 1.7 branch. (will trigger another build
from comet to get verifiable bits)

Comment 7

[chris hofmann]

Comment on attachment 147033 [details] [diff] [review]
don't just strip .so files; run strip on all files, since it ignores files that don't have recognizable debugging symbols

a=chofmann for 1.7

Comment 8

[Daniel (Leaf) Nunes]

committed to branch.