241329 - Spidermonkey doesn't build with OpenWatcom

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

ok, I tried to compile spidermonkey with openwatcom, using:
make -f Makefile.ref
result:
jsapi.c(267): Error! E1071: Type of parameter 5 does not agree with previous def
inition
jsapi.c(267): Note! N2003: source conversion type is 'char **'
jsapi.c(267): Note! N2004: target conversion type is 'char *(*)[1]'
jsapi.c(370): Error! E1071: Type of parameter 5 does not agree with previous def
inition
jsapi.c(370): Note! N2003: source conversion type is 'char **'
jsapi.c(370): Note! N2004: target conversion type is 'char *(*)[1]'
make[1]: *** [WINNT5.1_DBG.OBJ/jsapi.obj] Error 255

(note: I am not sure this is the best way. however, the build instructions at
http://lxr.mozilla.org/mozilla/source/js/src/README.html claim being out of
date, and "nmake /f js.mak" fails with makefile errors)

Spidermonkey compiles (doesn't link) with:
make -f Makefile.ref XCFLAGS=-DHAVE_VA_LIST_AS_ARRAY

should Makefile.ref define that somehow? or is it only supposed to work in
combination w/ mozilla (configure seems to check for it)?

Comment 1

[timeless]

I think we want to change jscpucfg.c, see bug 59195

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

hmm, looking at jstypes.h, jsautocfg.h doesn't seem to be used (for normal config):
#if (defined(XP_MAC) || defined(XP_WIN)) && !defined(CROSS_COMPILE)
#    include "jscpucfg.h"        /* Use standard Mac or Windows configuration */


I'll change jscpucfg.h instead

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 146792 [details] [diff] [review]
patch

r=me, thanks.

/be

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

(In reply to comment #0)
> Spidermonkey compiles (doesn't link) with:

it actually does link if I don't have a leftover LIB env var from MSVC. crashes
when starting js.exe though... but that's a separate bug.

checked in on trunk:
Checking in jscpucfg.h;
/cvsroot/mozilla/js/src/jscpucfg.h,v  <--  jscpucfg.h
new revision: 3.16; previous revision: 3.15
done