241342 - notfound.wav is an invalidly formatted wav file.

Status: RESOLVED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040421
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040421

mozilla/extensions/typeaheadfind/resources/content/notfound.wav
is invalid.
Its file's header and data are not in agreement.

This bug comes bugizlla-jp.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=3745

In the reporter's environment, WinXP was crashed(blue screen) when the sound was
called. His sound card is "waveterminal2496".

Reproducible: Always
Steps to Reproduce:
1. Type the key that text is not exists in the current page.
2.
3.

Actual Results:  
In several environment, we can see the "blue screen".

Expected Results:  
In all environment, works fine.

I reconverted the file.
Download from following URI.(application/zip)
http://bugzilla.mozilla.gr.jp/attachment.cgi?id=2190&action=view

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And when the file read on Premire LE,
its process does not work fine...

Comment 2

[Frank Wein [:mcsmurf]]

Do you have a tool which proves that this file (headers) are invalid?

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I see the file with binary editor.
The file is not generally "rate" and "average byte per second" and having
unknown chunk 'acpr'.(Some tools were not able to read this file.
e.x. http://www.maxim.abel.co.uk/utilities.htm )

On an actural, the file makes to crash on WinXP with "waveterminal2496",
and Adobe PremireLE was made unstable on Win2000 with "ADI AD1980 SoundMAX".

I reconverted to 22.05kHz.
The new file works fine on the WinXP with "waveterminal2496".

I don't have enough knowlage of wave format,
but non-generally format should not be used in application resource.

Comment 4

[Aaron Leventhal]

If someone wants to make a better sound, that would be great:
There are some attempts at this in this bug:
bug 185905 (make better sound for find as you type)

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Aaron:
It is so good, however stable branch(1.7) should not have the unstable file.

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: resaved version

This is a the original file, re-saved with Audacity and converted to 22050hz.
Can you check back if this version works better for the people who have this
problem?

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, 2:00 AM in Japan.
Please wait.

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The original file is 44.1kHz.
Do you use this file?

Comment 9

[Frank Wein [:mcsmurf]]

(In reply to comment #8)
> The original file is 44.1kHz.
> Do you use this file?

Audacity tells me it's 22245Hz, maybe Audacity is wrong here?

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

# Sorry, previous my comment's "the original file" is attachment 146855 [details]. 

Current notfound.wav is 22254Hz(non-generally).
Nearest audacity generally is 22050Hz.
44100Hz is not wrong. but the quality is better than current file :-)

Comment 11

[Frank Wein [:mcsmurf]]

(In reply to comment #10)
> 44100Hz is not wrong. but the quality is better than current file :-)

But the quality won't get better because the raw audio file has lower quality.

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

(In reply to comment #5)
> Aaron:
> It is so good, however stable branch(1.7) should not have the unstable file.

Confirming: working well.
{{
1 444 b; November 9th 2002;
0.31 s; PCM 22.254 Hz, 16 bits, Mono
}}

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Frank:
The original reporter (in Bugzilla-jp) said that attachment 146855 [details] works fine in
his environment.

Serge:
> Confirming: working well.

We tested on many environment.
In many case, we know that works fine.
This problem is related to hardware driver's bug or other issues.
However, if the file is replaced to the better format,
this problem is made to fix.

Comment 14

[Frank Wein [:mcsmurf]]

Comment on attachment 146855 [details]
resaved version

Aaron, could you review this?

Comment 15

[Andrew Hagen]

Confirming as per comment 12.

Comment 16

[Aaron Leventhal]

Comment on attachment 146855 [details]
resaved version

r=aaronl, but I really wish someone would make a better sound, something not so
scratchy. Have you tried playing this on various platforms like Mac and Linux
to see how it sounds?

Comment 17

[tenthumbs]

Attachment: 44100 16-bit WAVE

How about this. I tried for a reasonable match to the frequency spectrum of the
original. It's longer and larger but sounds better.

Comment 18

[HARUNAGA Hirotoshi]

It seems to me that attachment 146855 [details] sounds similarly to the current
notfound.wav on FreeBSD and Mac.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 146855 [details]
resaved version

a=asa (on behalf of drivers) for checkin to 1.7

Comment 20

[Asa Dotzler [:asa]]

not going to block the release if this hasn't landed in time for it but it is
approved to land so can someone please check it into the 1.7 branch as soon as
possible?

Comment 21

[Kenneth Herron]

Checked in on the trunk:
Checking in notfound.wav;
/cvsroot/mozilla/extensions/typeaheadfind/resources/content/notfound.wav,v  <--
 notfound.wav
new revision: 1.4; previous revision: 1.3
done

Checked in on MOZILLA_1_7_BRANCH:
Checking in notfound.wav;
/cvsroot/mozilla/extensions/typeaheadfind/resources/content/notfound.wav,v  <--
 notfound.wav
new revision: 1.3.50.1; previous revision: 1.3
done

Resolving FIXED.