241507 - Don't create new rendering contexts for each caret drawn on unix platforms

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

See bug 28068, bug 51747, and
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/base/src/nsCaret.cpp&rev.1.123&mark=68-72#68

I can't seem to find any reference of issues with unix platforms, though, and
I've been running on linux with the define turned off for a while without issue,
and have even ran for a short while in caret browsing mode and haven't noticed
any problems with caret drawing.

So, I propose we turn off this define for XP_UNIX && !XP_MACOSX platforms, and
get some feedback in the 1.8alpha cycle.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Proposed patch

Comment 2

[Simon Fraser [no longer active]]

Dup of bug 28068?

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 146878 [details] [diff] [review]
Proposed patch

smfr, not sure if you are doing reviews still, but here's hoping you are.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Oh there you are!

No, not exactly.  I intentionally didn't post this under that bug, because that
is supposedly the bug to fix whatever issues the other platforms have with this.
 I just want this for linux only instead of globally.

Comment 5

[Brian Ryner (not reading)]

Comment on attachment 146878 [details] [diff] [review]
Proposed patch

Sure, let's find out what breaks.

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Simon, what say you?  I'd like to get this in for testing...

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

I just landed this.  Be on the lookout for potential fallout.  ;-)

Comment 8

[Hiro]

Doesn't it checkin to AVIARY_1_0_20040515_BRANCH?

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

No.  I have no intention whatsoever of landing this on any branches.

Comment 10

[Mark Banner (:standard8)]

Christopher, your patch for these seems to have caused several bugs on linux
when using GTK 1 - they all seem to be related areas, and I have just tried
backing out your changes on a fairly recent (1-2 days) cvs build and the
problems are resolved.

Bug 259302 - focussing, removing tabbox crashes mozilla on linux
Bug 265148 - Crash after clearing a mailnews folder search.
Bug 254049 - While adding an email address via addressbook to an email mozilla
crashes

254049 is the main tracking one, the others have been marked as dups.