Closed
Bug 241524
Opened 20 years ago
Closed 20 years ago
Shift-J does not work as keyboard shortcut for Message -> Mark ->As Not Junk
Categories
(SeaMonkey :: MailNews: Message Display, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: cyberpastor, Assigned: mkaply)
Details
(Keywords: verified1.7)
Attachments
(1 file)
881 bytes,
patch
|
jhpedemonte
:
review+
mkaply
:
superreview+
mkaply
:
approval1.7+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422 MultiZilla/1.6.3.0d Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422 MultiZilla/1.6.3.0d Although J works as keyboard shortcut for Message -> Mark -> As Junk, Shift-J does not work as keyboard shortcut for Message -> Mark -> As Not Junk Shift-J does nothing at all. Reproducible: Always Steps to Reproduce: 1. Highlight a Mail message 2. Press Shift-J 3. Actual Results: Nothing Expected Results: Message should be marked as Not Junk
Originally fixed in bug 188934. WFM: 20040424, Linux
Comment 2•20 years ago
|
||
mkaply asked for someone to file this bug so he could attach a patch already prepared
Assignee: sspitzer → mkaply
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•20 years ago
|
||
We were setting isShift to False which I don't understand. When I looked at why that code was originally added, I was led to bug 104371 Removing this code did NOT break 104371 - I've no idea why this wasn't removed in that bug as other platforms had it removed. Anyway, in lookint at the testcase in bug 104371, I found another issue - OS/2 is getting a popup in that testcase for the Alt key. Come to find out, we shouldn't be doing NS_KEY_PRESS unless we have a char value. I've done a lot of testing and this doesn't regress anything and it fixes the Alt problem.
Assignee | ||
Updated•20 years ago
|
Attachment #146897 -
Flags: review?(pedemont)
Updated•20 years ago
|
Attachment #146897 -
Flags: review?(pedemont) → review+
Assignee | ||
Comment 4•20 years ago
|
||
Comment on attachment 146897 [details] [diff] [review] Fix for problem sr=blizzard (platform specific) a=mkaply (OS/2 only)
Attachment #146897 -
Flags: superreview+
Attachment #146897 -
Flags: approval1.7+
Assignee | ||
Comment 5•20 years ago
|
||
Fix checked in.
Comment 6•20 years ago
|
||
Verified as fix for the latest Mozilla nightly 06-15 build.
Comment 7•20 years ago
|
||
This has been marked as verified since verification has been done for both 1.7 branch & trunk 06-15 builds.
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•