241524 - Shift-J does not work as keyboard shortcut for Message -> Mark ->As Not Junk

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Alan Beagley]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422 MultiZilla/1.6.3.0d
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.7b) Gecko/20040422 MultiZilla/1.6.3.0d

Although J works as keyboard shortcut for Message -> Mark -> As Junk, 

Shift-J does not work as keyboard shortcut for Message -> Mark -> As Not Junk

Shift-J does nothing at all.

Reproducible: Always
Steps to Reproduce:
1. Highlight a Mail message
2. Press Shift-J
3.

Actual Results:  
Nothing

Expected Results:  
Message should be marked as Not Junk

Comment 1

[R.K.Aa.]

Originally fixed in bug 188934. WFM: 20040424, Linux

Comment 2

[Felix Miata]

mkaply asked for someone to file this bug so he could attach a patch already
prepared

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

We were setting isShift to False which I don't understand.

When I looked at why that code was originally added, I was led to bug 104371

Removing this code did NOT break 104371 - I've no idea why this wasn't removed
in that bug as other platforms had it removed.

Anyway, in lookint at the testcase in bug 104371, I found another issue - OS/2
is getting a popup in that testcase for the Alt key.

Come to find out, we shouldn't be doing NS_KEY_PRESS unless we have a char
value.

I've done a lot of testing and this doesn't regress anything and it fixes the
Alt problem.

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 146897 [details] [diff] [review]
Fix for problem

sr=blizzard (platform specific)
a=mkaply (OS/2 only)

Comment 5

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 6

[Karen Huang]

Verified as fix for the latest Mozilla nightly 06-15 build.

Comment 7

[Karen Huang]

This has been marked as verified since verification has been done for both 1.7
branch & trunk 06-15 builds.