Closed
Bug 241697
Opened 21 years ago
Closed 21 years ago
Bulletproof the prefservice for multiple startup of XPCOM
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla1.8alpha1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
Attachments
(1 file)
|
3.97 KB,
patch
|
darin.moz
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
Right now, if we leak the prefservice we don't cleanup global variables in the
prefservice properly. This fixes that, and issues a debug warning about the leak.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147021 -
Flags: superreview?(darin)
Attachment #147021 -
Flags: review?(darin)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 147021 [details] [diff] [review]
bulletproof prefs in the module destructor
thanks for catching the JS remnant
Attachment #147021 -
Flags: superreview?(darin)
Attachment #147021 -
Flags: superreview+
Attachment #147021 -
Flags: review?(darin)
Attachment #147021 -
Flags: review+
|
|
Assignee | |
Comment 3•21 years ago
|
||
Checked in on moz trunk. This should be backported to the firefox 0.9 branch
when that exists.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•