241700 - alt+spacebar must be pressed twice to activate Windows control menu

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Jason Ellis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040425 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040425 Firefox/0.8.0+

The Windows control menu does not show when alt+spacebar is pressed the first
time; it must be pressed twice to show the menu.  This shortcut works fine in
Thunderbird and suite.  One can also show this menu by clicking on the icon in
the top left of the window, but the shortcut is very useful.

Reproducible: Always
Steps to Reproduce:
1. Start Firefox
2. Press Alt+spacebar (nothing happens)
3. Press Alt+spacebar (Windows control menu displays)

Actual Results:  
Nothing happens after first press of alt+spacebar.  When alt+spacebar is pressed
again, the Windows control menu shows as it should the first time.

Expected Results:  
I expected the Windows control menu to display in the top lefthand corner of the
window on the initial press of alt+spacebar.

Comment 1

[Carlos C.]

It happens in windows xp sp1 also.

Comment 2

[Jesse Ruderman]

Regressed between 04/17 and 04/22 (Firefox nightlies).

Still happens in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a)
Gecko/20040430 Firefox/0.8.0+

Ere, this regression happened around the same time as bug 241447.  Is it yours too?

Comment 3

[Ere Maijala (slow)]

Could be my bad, and it's not FF only. I tested alt-space, but it works fine
when for example url bar has focus. When content has focus, two presses are
needed. I'll investigate. 

Comment 4

[Ere Maijala (slow)]

Attachment: Patch

The state of modifier keys must be checked in WM_CHAR too, because a child
window (such as the content area) could just let that one go through to the
parent window.

Comment 5

[Ere Maijala (slow)]

Comment on attachment 147437 [details] [diff] [review]
Patch

Requesting reviews for yet another key handling fix..

Comment 6

[[e-mail]]

Comment on attachment 147437 [details] [diff] [review]
Patch

I did wonder but at the time I couldn't think how you could get a WM_CHAR
without a WM_KEYDOWN first.

Comment 7

[Rev. Aaron D. Marasco]

If it helps, Windows XP SP1:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040426

Same problem... I've noticed that letting go of the Alt key is optional. So:

Alt-Space-Space works too...

Comment 8

[Ere Maijala (slow)]

Fix checked in.

Comment 9

[Michael Lefevre]

removing nomination for 1.0 - sounds like this was a trunk bug