241952 - Change XUL nsprlogging to spam all:4/all:5 instead of all:2

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[timeless]

Currently xul logs everything as if it's critical. This makes it fairly hard to
read an all:2 log. I don't mind spamming all:5.

Comment 1

[timeless]

Attachment: attempt to pick reasonable log levels

Comment 2

[Boris Zbarsky [:bzbarsky]]

I'm not doing srs in the foreseeable future.  See the reviewers page...  Please
ask someone else?

Comment 3

[[e-mail]]

Comment on attachment 147228 [details] [diff] [review]
attempt to pick reasonable log levels

A few extra PR_LOG_TESTs wouldn't go amiss.

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 147228 [details] [diff] [review]
attempt to pick reasonable log levels

> nsresult
> nsXULDocument::StartLayout(void)
> {
>     if (!mRootContent) {
> #ifdef PR_LOGGING
>         nsCAutoString urlspec;
>         mDocumentURI->GetSpec(urlspec);
> 
>-        PR_LOG(gXULLog, PR_LOG_ALWAYS,
>+        PR_LOG(gXULLog, PR_LOG_WARNING,
>                ("xul: unable to layout '%s'; no root content", urlspec.get()));

---------------------
> nsXULDocument::OverlayForwardReference::~OverlayForwardReference()
> {
> #ifdef PR_LOGGING
>-    if (PR_LOG_TEST(gXULLog, PR_LOG_ALWAYS) && !mResolved) {
>+    if (PR_LOG_TEST(gXULLog, PR_LOG_WARNING) && !mResolved) {
>         nsAutoString id;
>         mOverlay->GetAttr(kNameSpaceID_None, nsXULAtoms::id, id);
> 
>         nsCAutoString idC;
>         idC.AssignWithConversion(id);
>-        PR_LOG(gXULLog, PR_LOG_ALWAYS,
>+        PR_LOG(gXULLog, PR_LOG_WARNING,
>                ("xul: overlay failed to resolve '%s'",

Should the above two spots be PR_LOG_ERROR instead?

If neil's happy I'm fine with it.
sr=dveditz

Comment 5

[[e-mail]]

The second one is harmless, it's useful for overlays that are used in multiple
windows and won't know which ids will be available in advance.

Comment 6

[timeless]

mozilla/content/xul/document/src/nsXULCommandDispatcher.cpp 	1.78
mozilla/content/xul/document/src/nsXULContentSink.cpp 	1.140
mozilla/content/xul/document/src/nsXULDocument.cpp 	1.626
mozilla/content/xul/document/src/nsElementMap.cpp 	1.25