241966 - Mozilla/Firefox/Thunderbird can't launch each other

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Mike Kaply [:mkaply]]

Since OS/2 doesn't have a global registry for protocols like Windows does, there
is no way for us to send http/https/news/mailto/ftp to the operating system.

Actually, there is a way to send http/https, we just aren't doing it.

An app was created to configure defaults for everything on OS/2:

http://hobbes.nmsu.edu/cgi-bin/h-viewer?sh=1&fname=/pub/os2/apps/misc/configapps1_0_0.zip

We should honor its values.

Initial patch coming.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Initial patch

this adds all the special casing.

Comment 2

[jhp (no longer active)]

Comment on attachment 147237 [details] [diff] [review]
Initial patch

+      if ((uProtocol == NS_LITERAL_CSTRING("http")) ||
+	   (uProtocol == NS_LITERAL_CSTRING("http")) ||

The second statement should say "https".

+	 PrfQueryProfileString(HINI_USER,
+			       "WPURLDEFAULTSETTINGS",
+			       "DefaultBrowserParameters",
+			       "",
+			       szParamsFromINI,
+			       sizeof(szParamsFromINI));

Did you say you were going to fall back to "DefaultParameters" if
"DefaultBrowserExe" exists, but "DefaultBrowserParameters" does not?

+      if (szAppFromINI[0]) {
+	 applicationName = szAppFromINI;
+	 parameters = szParamsFromINI;
+	 parameters += " ";
+	 parameters += urlSpec;
+      } else {
+	 return NS_ERROR_FAILURE;
+      }

You have this code twice.  Can't you just put it outside the large 'if'?

And there's a bunch of extra spaces at the end.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Cleanup that Javier suggested

Comment 4

[jhp (no longer active)]

Comment on attachment 147392 [details] [diff] [review]
Cleanup that Javier suggested

Still haven't changed "http" -> "https".  Otherwise, r=pedemonte

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 147392 [details] [diff] [review]
Cleanup that Javier suggested

sr=blizzard (platform specific)
a=mkaply (OS/2 only)
We need this for long lived TB and FF

Comment 6

[Mike Kaply [:mkaply]]

Fixed on trunk and branch