Closed
Bug 241966
Opened 20 years ago
Closed 20 years ago
Mozilla/Firefox/Thunderbird can't launch each other
Categories
(Core Graveyard :: File Handling, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mkaply, Assigned: mkaply)
Details
(Keywords: fixed1.7)
Attachments
(2 files)
4.70 KB,
patch
|
Details | Diff | Splinter Review | |
5.03 KB,
patch
|
jhpedemonte
:
review+
mkaply
:
superreview+
mkaply
:
approval1.7+
|
Details | Diff | Splinter Review |
Since OS/2 doesn't have a global registry for protocols like Windows does, there is no way for us to send http/https/news/mailto/ftp to the operating system. Actually, there is a way to send http/https, we just aren't doing it. An app was created to configure defaults for everything on OS/2: http://hobbes.nmsu.edu/cgi-bin/h-viewer?sh=1&fname=/pub/os2/apps/misc/configapps1_0_0.zip We should honor its values. Initial patch coming.
Assignee | ||
Comment 1•20 years ago
|
||
this adds all the special casing.
Comment 2•20 years ago
|
||
Comment on attachment 147237 [details] [diff] [review] Initial patch + if ((uProtocol == NS_LITERAL_CSTRING("http")) || + (uProtocol == NS_LITERAL_CSTRING("http")) || The second statement should say "https". + PrfQueryProfileString(HINI_USER, + "WPURLDEFAULTSETTINGS", + "DefaultBrowserParameters", + "", + szParamsFromINI, + sizeof(szParamsFromINI)); Did you say you were going to fall back to "DefaultParameters" if "DefaultBrowserExe" exists, but "DefaultBrowserParameters" does not? + if (szAppFromINI[0]) { + applicationName = szAppFromINI; + parameters = szParamsFromINI; + parameters += " "; + parameters += urlSpec; + } else { + return NS_ERROR_FAILURE; + } You have this code twice. Can't you just put it outside the large 'if'? And there's a bunch of extra spaces at the end.
Assignee | ||
Comment 3•20 years ago
|
||
Assignee | ||
Updated•20 years ago
|
Attachment #147392 -
Flags: review?(pedemont)
Comment 4•20 years ago
|
||
Comment on attachment 147392 [details] [diff] [review] Cleanup that Javier suggested Still haven't changed "http" -> "https". Otherwise, r=pedemonte
Attachment #147392 -
Flags: review?(pedemont) → review+
Assignee | ||
Comment 5•20 years ago
|
||
Comment on attachment 147392 [details] [diff] [review] Cleanup that Javier suggested sr=blizzard (platform specific) a=mkaply (OS/2 only) We need this for long lived TB and FF
Attachment #147392 -
Flags: superreview+
Attachment #147392 -
Flags: approval1.7+
Assignee | ||
Comment 6•20 years ago
|
||
Fixed on trunk and branch
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•