242011 - Firefox trunk build breaks in migration code on OS/2

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[jhp (no longer active)]

Breaks when building the nsOperaProfileMigrator.cpp.

Comment 1

[jhp (no longer active)]

Attachment: patch to disable Opera migrator

For now, disable the Opera migrator on OS/2.

There was a version of Opera available for OS/2, but that was version 5, and
this code seems to only reference Opera 6.  Ben, will this code work with
versions of Opera prior to version 6?

Kaply, do you think it is even worthwhile getting this to work on OS/2?  Do we
have any customers that use/used Opera?

Comment 2

[timeless]

we're presuming it works w/ older versions of opera for beos :)

Comment 3

[Mike Kaply [:mkaply]]

Why can't we compile the code?

What actually breaks?

Comment 4

[jhp (no longer active)]

What breaks is that the Opera defines at the top of nsOperaProfileMigrator.cpp
are only defined for Unix, Mac, and Win32, but is referrenced in the code for
all platforms.

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 147269 [details] [diff] [review]
patch to disable Opera migrator

r=mkaply

Comment 6

[Mike Kaply [:mkaply]]

Attachment: XUL change

The XUL had no default, so it did nothing on platforms other than XP_UNIX and
XP_MAC

Comment 7

[Mike Kaply [:mkaply]]

Fixes in to branch and trunk.

Note we still need to actually make migration work for OS/2.