242024 - gtk_moz_embed_set_app_components doesn't run mRegisterSelfProc

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

If you set components with gtk_moz_embed_set_app_components(), the components'
register proc (nsModuleComponentInfo.mRegisterSelfProc) isn't run when the
component's factory is created in EmbedPrivate::RegisterAppComponents().

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

Comment 2

[Christopher Blizzard (:blizzard)]

Comment on attachment 147277 [details] [diff] [review]
proposed fix

Unsure if this is how it's supposed to work, but the code looks fine.

Comment 3

[Marco Pesenti Gritti]

Looks like this doesnt apply anymore :/ Can you submit an updated patch please?

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: rediff'd patch (only whitespace changes)

Comment 5

[Marco Pesenti Gritti]

Patch checked in the trunk