242065 - "My Name" from account is ignored when email contains "special chars", full name extracted from email address

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Martin Kutschker]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.2) Gecko/20030208 Netscape/7.02

Settings
Your name: Martin T. Kutschker
Email address: Martin-no$[e-mail]


From: "Martin-no$pam-Kutschker" <"Martin-no$pam-Kutschker"@blackbox.n0spam.net>

Reproducible: Always
Steps to Reproduce:
Post any message on a news server.
Actual Results:  
From: "Martin-no$pam-Kutschker" <"Martin-no$pam-Kutschker"@blackbox.n0spam.net>

Expected Results:  
From: "Martin T. Kutschker" <"Martin-no$pam-Kutschker"@blackbox.n0spam.net>

Ok. the $ in the obfuscation address is fancy, but that's no excuse for ignoring
"Your Name".

Comment 1

[u63580]

Martin, from your user agent, you are using Netscape Communicator, and not
Mozilla.  While Netscape is based on Mozilla, bugs in Netscape should be
reported to them, and not here.  See for example:

http://channels.netscape.com/ns/browsers/faq.jsp#gen7

On how to report problems with Netscape.

Your version is also rather old, so the problem may well be fixed in Netscape
7.1, or of course in Mozilla (go to www.mozilla.org to download).

I'm afraid this will be marked INVALID

Comment 2

[Martin Kutschker]

I've seen this also on Mozilla (at least 1.5) on Windows. So it is not a
Netscape problem. I never noticed before until I tried those funky address.

Comment 3

[u63580]

Okay, I can reproduce this with a current ThunderBird build (20040426) on Win2k,
but only if the e-mail address contains a $ (I guess other special chars as
well).  When the e-mail address is okay, "your name" is used.

I suppose the bug desciption should be something like:

Your name / real name is ignored when e-mail address contains special characters

Comment 4

[Martin Kutschker]

Summary changed as per request of comment #3 in conformance with initial bug report.

Comment 5

[Christian Eyrich]

Confirmed with Mozilla 20040401 on Win98.

Comment 6

[Christian Eyrich]

Attachment: proposed patch

It happens to all addresses with a quoted local part, that is
<"localpart"@domain.tld> (those addresses are allowed by RFC 2822).

I tracked this down to construct_addresslist() and while a flag there is called
"quoted", I think it refers to a quoted realname and doesn't know anything of
quoted-string in the local-part.

While I'm not fully understand the function and I couldn't test all possible
variations to write an address, this patch should do it.
It just disables collecting the displayname from within the addr-spec.

Comment 7

[Christian Eyrich]

Who's best to have a look at this code? Scott, any idea?

Comment 8

[Scott MacGregor]

that patch seems ok Christian. Certaiinly enough for us to try out and see how
it works.

Comment 9

[Christian Eyrich]

Ok, great. Feel free to tack your review on it and check it in if you like.

Comment 10

[Scott MacGregor]

I checked this in. Let's see how it tests out. closing for now. will re-open if
it breaks something