242069 - "Manage Security Devices" and "Manage Certificates" does not work (error "openDeviceManager is not defined" etc. shown in Javascript Console)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Christian Weyland]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040411 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040427 Firefox/0.8.0+

When clicking one of the Buttons from Tools->Options->Advanced, nothing happens
and an error is shown in the Javascript Console.

Errors as following
-------------------
Error: openDeviceManager is not defined
Error: openCertManager is not defined
Error: openCrlManager is not defined


Reproducible: Always
Steps to Reproduce:




I'm seeing this since more than a week. 
properly working in build 20040411, NOT working in build 20040427.

Comment 1

[PikeUK]

See:

http://bonsai.mozilla.org/cvsquery.cgi?file=pref-advanced.xul&date=explicit&mindate=2004-04-21+01%3A47&maxdate=2004-04-21+01%3A47

Looks like someone forgot to move the code to pref-advanced.js :-)

Comment 2

[Steffen Wilberg]

No, the code is in place in pref-advanced.js. But it's inside of "#ifdef
PROVISIONAL_SECURITY_UI". The corresponding #define is in pref-advanced.xul.

The preprocessor doesn't notice the #define when it processes pref-advanced.js.
I already tried to move the xul file above the js file in the jar.mn, but to no
avail.

I guess we simply have to put a "#define PROVISIONAL_SECURITY_UI" in the js file.

Comment 3

[Steffen Wilberg]

Attachment: put a "#define PROVISIONAL_SECURITY_UI" in pref-advanced.js

Comment 4

[Mike Connor [:mconnor]]

this is all moot before 0.9, since the provisional UI is gone to be replaced by 
its permanent form.  (Once extension manager work is all done/checked in, the 
prefpanel rewrite can go in).

ben's just not especially careful with stuff he's changing anyway, I don't 
blame him :)

Comment 5

[Steffen Wilberg]

But it's easy enough to fix in the meantime, isn't it?

Comment 6

[Mike Connor [:mconnor]]

yeah, sure, but ben's not going take the time to review it/check it in if he's 
going to have the prefpanel work in after another week.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 147307 [details] [diff] [review]
put a "#define PROVISIONAL_SECURITY_UI" in pref-advanced.js

prefpanel rework is post-0.9, so let's get this done

Comment 8

[Steffen Wilberg]

Thanks Mike, can you check it in, please? I don't have a cvs account.
Btw, since when are you doing Firefox reviews? I don't see you listed in
http://www.mozilla.org/projects/firefox/review.html !?
Not that I would complain though ;-)

Comment 9

[Mike Connor [:mconnor]]

Steffen, I'm not a peer, but ben gave the OK for doing reviews on minor stuff
like this, I won't be making UI decisions or doing major reviews, at least not
at this point.

checked in on trunk 2004-05-02 10:11, does not exist on branch as of yet.

Comment 10

[Steffen Wilberg]

Nice to hear! Getting reviews was a major bottleneck in the past, even for minor
stuff like this.

Comment 11

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change