242082 - Help Viewer TOC topic-loading broken on 20040428

Status: VERIFIED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Joel Nelson (don't send email)]

The Firefox Help program is broken on the OS X 20040428 nightly build.  The
contents can be viewed but not the individual help documents (nothing happens
when clicked on in Help Contents).   The Help Viewer UI also is still the
Windows/Linux "Qute" theme rather than Pinstripe.

Comment 1

[Jeff Walden [:Waldo]]

Give it a try with the 20040429 build.  The fix for it was checked in last night.

Comment 2

[R.J. Keller]

Bug reproduced on Firefox 0.8.0+ 20040429 on Windows XP Home Edition.

Neil: Can you help with finding the cause of this issue? It is the exact same
RDF code as in seamonkey but yet a problem is occuring. When you click on a item
in the tree, nothing happens. There is no JS errors, even in debugging mode.

Comment 3

[Steffen Wilberg]

I can reproduce this with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a)
Gecko/20040430 Firefox/0.8.0+ (Steffen).
-> All/All.

Comment 4

[Bernard Alleysson]

happens with 20040501 sources on Windows

Comment 5

[Mike Connor [:mconnor]]

is this present on the branch as well or just trunk builds?

Comment 6

[Steffen Wilberg]

This is a regression from rlk's "help 1.1" landing on 2004-04-28 16:25 on the
trunk (bug 238221). It hasn't landed on the branch yet:
http://bonsai.mozilla.org/cvsquery.cgi?who=rlk%25trfenv.com&date=explicit&mindate=2004-04-28+16%3A25

But I guess rlk plans to do that as soon as this bug is fixed because he wanted
it to land for Firefox 0.9 (and 1.0) as well.

Comment 7

[u60234]

Actually, I think this regressed before Firebird Help 1.1. I see this bug on Win
XP with trunk build 2004-04-17-09, but not with 2004-04-16-10.

Maybe Jan Varga's tree widget changes have something to do with this.

Comment 8

[Jan Varga [:janv]]

Attachment: fix

Comment 9

[Jan Varga [:janv]]

I think there's no need to use cell properties to load a URI.
So I simplified it a little bit and fixed the regression.
Neil, would you review it?

Comment 10

[R.J. Keller]

Comment on attachment 147491 [details] [diff] [review]
fix

This patch looks good! I thoroughly tested this patch, and it works very well!

I'll check this in in a sec.

Comment 11

[R.J. Keller]

OK, Fix checked in.

Thanks a lot for the fix, Jan!

Comment 12

[Steffen Wilberg]

v.
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a) Gecko/20040502 Firefox/0.8.0+
(Steffen)