242098 - widgets missing in search when first opened

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[R.K.Aa.]

current trunk CVS, Linux

Open Tools->Search Messages:
The search window lack the two selects and form for filling in a search term 

I see these warnings in JS console:

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]"  nsresult: "0x80004002
(NS_NOINTERFACE)"  location: "JS frame ::
chrome://messenger/content/SearchDialog.js :: setupDatasource :: line 524" 
data: no]

Error: gCurrentFolder has no properties
Source File: chrome://messenger/content/SearchDialog.js
Line: 402

Error: gCurrentFolder has no properties
Source File: chrome://messenger/content/SearchDialog.js
Line: 402

Error: gMailSession has no properties
Source File: chrome://messenger/content/SearchDialog.js
Line: 281


If i click the "clear" button, the widgets appear, but are empty.
If i then select another mailbox, the widgets "fill in" select options and can
be used.

I believe this is a regression. An otherwise identical build from the 25th is OK.

Comment 1

[WADA:World Anti-bad-Duping Agency]

Comfirmed with 2004042808-trunk/Win2K.

Comment 2

[james davis]

confirmed ditto Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a)
Gecko/2004042909 (trunk)

Comment 3

[R.K.Aa.]

neil checked in at 2004-04-28 05:48 for bug 226270.
Backing that out cures this bug:

cvs update -j1.84 -j1.83
mozilla/mailnews/base/search/resources/content/SearchDialog.js
cvs update -j1.19 -j1.18 mozilla/mailnews/base/search/src/nsMsgSearchSession.h
cvs update -j1.50 -j1.49 mozilla/mailnews/base/search/src/nsMsgSearchSession.cpp
cvs update -j1.28 -j1.27 mozilla/mailnews/base/search/public/nsIMsgSearchSession.idl
cvs update -j1.31 -j1.30 mozilla/mailnews/base/resources/content/searchBar.js

Comment 4

[David :Bienvenu]

Attachment: proposed fix

Comment 5

[David :Bienvenu]

Neil has cleaned up after me so many times...returning the favor in a small way :-)

Comment 6

[[e-mail]]

Attachment: Actual fix

I forgot to delete the variable in my bug 226270 patch :-(

Comment 7

[[e-mail]]

Comment on attachment 147407 [details] [diff] [review]
Actual fix

Whomever gets there first, feel free to r/sr this trivial deletion :-)

Comment 8

[[e-mail]]

Fix checked in. Sorry for causing this :-[

Comment 9

[R.K.Aa.]

thanks for fixing it so quick :)