Closed
Bug 242149
Opened 21 years ago
Closed 21 years ago
GlobalWindowImpl gets prefs for no reason during page load and new-window
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
10.69 KB,
patch
|
caillon
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
GlobalWindowImpl ends up getting the dom.disable_window* prfes during new-window
and during page load for no reasons in some cases. This can be fixed by simply
not bothering to look at the pref if we're called from chrome, and only check
the pref if we're not called from chrome.
Patch coming up.
|
Assignee | |
Comment 1•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #147367 -
Flags: superreview?(bzbarsky)
Attachment #147367 -
Flags: review?(bzbarsky)
|
||
Comment 2•21 years ago
|
||
Comment on attachment 147367 [details] [diff] [review]
Make CanSetProperty() check if the caller is chrome before checking the pref.
I thought they were that way. See
http://bugzilla.mozilla.org/show_bug.cgi?id=117707#c68
Oops. r=caillon
Attachment #147367 -
Flags: review?(bzbarsky) → review+
|
||
Comment 3•21 years ago
|
||
Comment on attachment 147367 [details] [diff] [review]
Make CanSetProperty() check if the caller is chrome before checking the pref.
sr=bzbarsky
Attachment #147367 -
Flags: superreview?(bzbarsky) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•