242151 - document.body does not handle frameset properly if the document is XHTML

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

patch coming

Reproducible: Always
Steps to Reproduce:

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: if the document is XHTML, let's check the namespace

Comment 2

[Boris Zbarsky [:bzbarsky]]

Why not use NS_HTML_NAMESPACE from nsIElementFactory.h?  And maybe fix indentation?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: uses NS_HTML_NAMESPACE

If this is ok, could you bz or jst check this in?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 147393 [details] [diff] [review]
uses NS_HTML_NAMESPACE

maybe r+sr is enough

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 147393 [details] [diff] [review]
uses NS_HTML_NAMESPACE

+    if (IsXHTML())
+      rv = GetElementsByTagNameNS(NS_LITERAL_STRING(NS_HTML_NAMESPACE),
+				   NS_LITERAL_STRING("frameset"),
+					getter_AddRefs(nodeList));
+    else
+      rv = GetElementsByTagName(NS_LITERAL_STRING("frameset"),
					getter_AddRefs(nodeList));

Bad next-line indentation.

r+sr=jst

I fixed the indentation, and also consolidated some error handling to save a
byte or two of code. Checking in.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Erm... Won't NS_LITERAL_STRING(NS_HTML_NAMESPACE) break on compilers that use
Lfoo to implement NS_LITERAL_STRING??

Comment 7

[Johnny Stenback (:jst)]

Do we care? IIRC we do that elsewhere too. This is checked in, all tinderboxes
are green, including all ports.

Marking FIXED. Reopen if you think this is worth changing.