242157 - Deal with WSDL that has a <types> element with more than one <schema> children

Status: RESOLVED FIXED

(Core Graveyard :: Web Services, defect)

Description

[Harshal Pradhan]

If you try to mix RPC and Literal methods in the same service when using asmx
webservices, Visual Studio will generate a WSDL that has two schema elements
under the types element. It puts the SOAP RPC encoded types under one and the
ones needed for the Literal stuff under the other, and uses different
targetnamespaces. I will shortly attach an example wsdl generated from a
minimized C# testcase.

What VS is doing here looks prefectly legal and logical to me. But our WSDL
implementation assumes only one significant schema element under <types>. This
causes us to fail later on when processing the relevant <part> since the type
never got loaded by the schemaloader.

I have a fix.

Comment 1

[Harshal Pradhan]

Attachment: Example wsdl

This was generated by the .Net wsdl.exe. It cant be loaded by mozilla.

Comment 2

[Harshal Pradhan]

Attachment: Easy fix

Comment 3

[Harshal Pradhan]

Comment on attachment 147375 [details]
Example wsdl

Err .... oops

Comment 4

[Harshal Pradhan]

Attachment: Oops again.... this is *the* patch I swear.

Sorry for the spam. The last patch contained unrelated stuff from another bug,
I forgot to save the edited patch before submitting. Ignore that.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

I think we'll need to handle xs:import elements too here. Could you add a //
XXX comment if you think so too?

Comment 6

[Harshal Pradhan]

Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

Yeah, its possible to have import over there. I'll add the comment. 

Thanks, for the review. 

jst, could you please sr.

Comment 7

[Johnny Stenback (:jst)]

Maybe file a bug about handling import there too? :)

Comment 8

[Johnny Stenback (:jst)]

Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

sr=jst

Comment 9

[Harshal Pradhan]

Filed bug 242260 on the iport issue.

Checked in on trunk -> Fixed.

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

Trivial change that gets us one step closer to working with more web service
implementations out there. Nominating for 1.7.

Comment 11

[chris hofmann]

Comment on attachment 147377 [details] [diff] [review]
Oops again.... this is *the* patch I swear.

a=chofmann for 1.7

Comment 12

[Johnny Stenback (:jst)]

Fix landed on the 1.7 branch.