242261 - Save Page As... works only if Web Page, Complete is selected

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Bruce Wright]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.4) Gecko/20011022 Netscape6/6.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040430

In some earlier versions of Mozilla (eg, 1.4, NS 7.1) if you select search
criteria on this page and generate a report, then do a File->Save Page As...
then the page can be saved as either Web Page, Complete or Web Page, HTML only.
 In both cases the textual content of the report is saved.

In Mozilla 1.7rc1, if you generate the report and do a File->Save Page As...
then the textual content of the report is saved only if you select "Web Page,
Complete" in the File Save dialog.  If you select "Web Page, HTML only", then
the page that is saved does not have the report but instead says "Please select
at least one region or country."  However if you select "Web Page, Complete"
then the page that is saved has the complete report.

Reproducible: Always
Steps to Reproduce:
1. From the query page http://www.who.int/vaccines/casecount/case_count.cfm,
select "World" region in the left-hand listbox, "All" countries in the middle
listbox, and the year 2004 in the right-hand listbox.
2. Press "Submit Request."
3. When the report displays, select File, and then select Save Page As...
4. In the file select dialog, select "Web Page, HTML only"
5. Click OK
6. Open the saved file in Mozilla or another browser.

Actual Results:  
The saved file displays "Please select at least one region or country."  If you
save the page as "Web Page, Complete" then the entire report is displayed.

Expected Results:  
The saved file displays the generated report in either case.

Comment 1

[Hermann Schwab]

Attachment: LiveHTTPHeader for Save, Complete

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a) Gecko/20040429

Save Page, Complete sends HEAD and GET command, 
Save Page, HTML only, sends HEAD only.

The encoding is differently specified:
the server specifies:	 Content-Type: text/html; charset=UTF-8
the saved file specifies: <meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">

so UTF-8 § is displayed as Windows-1252  §, when looking at the saved page.

Comment 2

[Hermann Schwab]

Attachment: logged HEAD + GET from Save Page as: Web page, complete

Sorry, 1st attachment isn´t what I wrote.
previous attachment was a HEAD only, and another request, 
so it was from Save Page as: Web Page, HTML only.

Comment 3

[Hermann Schwab]

Attachment: HEAD + POST from working Mozilla 1.4.1

Mozilla 1.4.1 sends a GET when I submit the form, 
and sends a HEAD and a POST when I do  Save Page As: Web Page, HTML only.

Mozilla 1.7b sends a GET when I submit the form,
and sends a HEAD and a GET when I do  Save Page As: Web Page, HTML only.

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040316

Comment 4

[Hermann Schwab]

Regressed in Mozilla 1.7a, is working in Mozilla 1.6
Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.6) Gecko/20040113

Comment 5

[Hermann Schwab]

regressed between working BuildID 2003123008 and not-working BuildID 2003123008 

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7a) Gecko/20031230

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hermann, are those two build ids supposed to be identical?

Comment 7

[Hermann Schwab]

(In reply to comment #6)
> Hermann, are those two build ids supposed to be identical?

2003-12-23-08 was tested working, from the 2003-12-23-09 directory.
2003-12-30-08 was tested not-working.

Comment 8

[Hermann Schwab]

2003-12-23-08 working
2003-12-25-09 not-working

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2003-12-23-07&maxdate=2003-12-25-10&cvsroot=%2Fcvsroot

Comment 9

[Hermann Schwab]

BuildID 2003-12-24-09 working, 2003-12-25-09 regressed, tested on win98,
Zip-installs. Is this bug windows only?

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2003-12-24+07&maxdate=2003-12-25-10&cvsroot=%2Fcvsroot

Comment 10

[Boris Zbarsky [:bzbarsky]]

The bonsai URL in comment 9 is wrong -- it ends at 2am instead of the 10am it
wanted.

The right URL is
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2003-12-24+07%3A00%3A00&maxdate=2003-12-25+10%3A00%3A00&cvsroot=%2Fcvsroot

This was broken by the second patch in bug 228619 -- sessionHistory.index throws
after that patch and so the postdata is always null, breaking POST result pages.
 Should have caught that when reviewing...  :(

In any case, this absolutely needs to be fixed for 1.7.  Serge?

Comment 11

[Hermann Schwab]

also not working, but not regressed: edit.

If I want to edit the page, using Ctrl+E, the errormessage comes up.

Please select at least one region and or country!
Return to selection form

tested in 1.4.1, and 1.7a BuildID 2003122409 and 2003122509.
First two are saving the page, none of them can edit the page, so it is not a
regression.

The page is served, viewed and saved as UTF-8, but when loading the saved copy,
it is displayed as Windows-1252 according to it the metatag, so I must manually
set the character encoding to UTF-8 to get it right.
Is this TechEvangelism, as it is a server bug?
Can Mozilla know if the Server-Setting of UTF-8 or the file Metatag of
Windows-1252 is the correct one?  Wouldn´t it be nice to ask the User which
setting he prefers?

Comment 12

[Boris Zbarsky [:bzbarsky]]

One bug per issue, please.

Comment 13

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.7b) Gecko/20040421] (<-- 1.7rc1 !)
(W98SE)

(In reply to comment #10)
> This was broken by the second patch in bug 228619 -- sessionHistory.index throws
> after that patch

Obviously, as |sessionHistory| was the |var| which was removed :-(
The exception is |ReferenceError: sessionHistory is not defined|.

(Av1) Best action seems to be:
cvs update -j1.102 -j1.101
mozilla/xpfe/communicator/resources/content/contentAreaUtils.js

Neil, can you do it !? (assuming test=me, rs=bzbarsky)

Comment 14

[Boris Zbarsky [:bzbarsky]]

Yeah, just backing out that patch looks fine to me.  I just did so on the trunk,
in fact.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: What I just landed on trunk [Checked in: Comment 14 & 17]

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 147506 [details] [diff] [review]
What I just landed on trunk
[Checked in: Comment 14 & 17]

Could this please be approved for 1.7? This just backs out an erroneous
patch...

Comment 17

[Boris Zbarsky [:bzbarsky]]

Checked in on the branch.

Comment 18

[Tracy Walker [:tracy]]

verified, save web page as HTML works as expected on 1.7