242346 - "Customize Character Encoding" dialog doesn't remember its size and position and is opened to small when using larger fonts

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Stefan Borggraefe]

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Comment 2

[[e-mail]]

Comment on attachment 147494 [details] [diff] [review]
Patch

>-<dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
>+<dialog id="customizeCharacterEncoding"
>+        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
Although I don't see the point of inserting the id before the xmlns...

Comment 3

[Stefan Borggraefe]

Comment on attachment 147494 [details] [diff] [review]
Patch

I can change the order of the attributes before the checkin.

Comment 4

[jag (Peter Annema)]

Comment on attachment 147494 [details] [diff] [review]
Patch

Why did you change width and height to style=...?

Comment 5

[Stefan Borggraefe]

(In reply to comment #4)
> (From update of attachment 147494 [details] [diff] [review])
> Why did you change width and height to style=...?

The width and height attributes only support pixel values. With pixel values
dialgs and windows are to small when using larger fonts.

The style attribute works fine with other units, especially em. When used like
this, the initial size of the dialog is adaptive to the used font size.

I already fixed a lot of dialogs and windows this way which were truncated when
larger fonts were used.

So this change is for the "opened to small when using larger fonts" part of this
bug.

Comment 6

[Stefan Borggraefe]

jag: ping

Comment 7

[Alec Flett]

Comment on attachment 147494 [details] [diff] [review]
Patch

sr=alecf

Comment 8

[Stefan Borggraefe]

Fixed.