Closed
Bug 242404
Opened 21 years ago
Closed 21 years ago
Files fieldMapExport.* are unused and can be removed
Categories
(SeaMonkey :: MailNews: Address Book & Contacts, defect)
SeaMonkey
MailNews: Address Book & Contacts
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Stefan.Borggraefe, Assigned: Stefan.Borggraefe)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
17.81 KB,
patch
|
neil
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
Are there any plans for these files or can they be removed? I could make the
patch in the latter case.
|
Assignee | |
Comment 1•21 years ago
|
||
This code looks really ancient, is incomplete and isn't hooked up. Even if
someone decides to implement this feature in the future (Bug 116977) these
files would IMHO be of little use.
There's no reason to include them in our builds.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #148724 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Comment 2•21 years ago
|
||
Comment on attachment 148724 [details] [diff] [review]
Patch to remove the files
Sorry, this patch is not correct.
Attachment #148724 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
Assignee | |
Comment 3•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #148724 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•21 years ago
|
Attachment #148726 -
Flags: review?(neil.parkwaycc.co.uk)
|
||
Updated•21 years ago
|
Attachment #148726 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Assignee | |
Updated•21 years ago
|
Attachment #148726 -
Flags: superreview?(bienvenu)
|
||
Updated•21 years ago
|
Attachment #148726 -
Flags: superreview?(bienvenu) → superreview+
|
|
Assignee | |
Comment 4•21 years ago
|
||
Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Summary: Files fieldMapExport.* are unused and can probably be removed → Files fieldMapExport.* are unused and can be removed
|
|
||
Comment 5•21 years ago
|
||
Actually the second patch was not correct either, it deleted the contents rather
than removing the files (you need to cvs rm + cvs diff -N).
|
|
Assignee | |
Comment 6•21 years ago
|
||
(In reply to comment #5)
> Actually the second patch was not correct either, it deleted the contents rather
> than removing the files (you need to cvs rm + cvs diff -N).
Ah, I wasn't sure how to make a diff when removing files. I just replaced the
files to remove with empty files locally so their content show up in the diff.
On checkin I did the actual cvs rm.
I just added -N to the diff line in my .cvsrc. Thanks for the hint! :-)
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•