242494 - submit button with "submit(); return false" not working

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Rob Borek]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040503 Firefox/0.8.0+ (BlueFyre)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040503 Firefox/0.8.0+ (BlueFyre)

On the page https://groupwise.wlu.ca:51443/servlet/webacc (which is a Novell
Groupwise login page), the Submit button does not work - clicking Submit does
nothing. This is a regression - the 20040430 trunk worked fine, stopped working
with 20040502 (not sure if 20040501 worked).

Reproducible: Always
Steps to Reproduce:
1. Enter any login and password information
2. Click on Login

Actual Results:  
Nothing

Expected Results:  
Proceeded with logging in to Groupwise

Comment 1

[Boris Zbarsky [:bzbarsky]]

> the 20040430 trunk worked fine

2004-04-30 when?  morning?  Evening?   2004-05-01-08 does not work.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Actually, this looks like likely fallout from bug 60212.. I'm not seeing this in
my build (which has all the changes I landed on the 30th, but not the event change).

Comment 3

[Rob Borek]

(In reply to comment #1)
> > the 20040430 trunk worked fine
> 
> 2004-04-30 when?  morning?  Evening?   2004-05-01-08 does not work.

It was a custom build of FireFox, built in the morning.

Comment 4

[Sean Kent]

Also seeing this at: http://mail.atl.devry.edu/servlet/webacc

Pressing the Login button does nothing.  I've tested using the Official Win32
nightly build from 20040430 - works fine with this build but not with any
official Win32 builds from 20040501 to present.  Apparently the bug is also
showing in Mac builds, as evidenced by this thread:
http://forums.mozillazine.org/viewtopic.php?t=74443

Comment 5

[Boris Zbarsky [:bzbarsky]]

Sean, I doubt that you're seeing this bug, since my build with the fix for bug
242503 worksforme on that site (so you're probably seeing a variant of that
problem).  If you could retest once that patch is checked in, that would be much
appreciated.

Comment 6

[Dan M]

Same as bug 242709. Closing as a duplicate of that one because it has a simple
test case some analysis.

*** This bug has been marked as a duplicate of 242709 ***

Comment 7

[Dan M]

My mistake. The same checkin created this bug and bug 242709, but the testcases
are slightly different and the mechanism of breakage is slightly different as
well. Reopening. Note this is almost certainly the same as bug 242439.

Comment 8

[Dan M]

*** Bug 242439 has been marked as a duplicate of this bug. ***

Comment 9

[Dan M]

Attachment: simpler test case

Comment 10

[Dan M]

*** Bug 242469 has been marked as a duplicate of this bug. ***

Comment 11

[Dan M]

*** Bug 242976 has been marked as a duplicate of this bug. ***

Comment 12

[Asaf Romano (gone)]

Evem the wikipedia edit form doesn't work.

Comment 13

[Johnny]

This bug also stops paypal transactions, so most ebay users won't be able to pay
for their auctions in an efficient manner.

Comment 14

[Bill Mason]

*** Bug 243703 has been marked as a duplicate of this bug. ***

Comment 15

[Robert Parenton]

*** Bug 243260 has been marked as a duplicate of this bug. ***

Comment 16

[Brendan Eich [:brendan]]

bryner, is this gonna get fixed soon?

/be

Comment 17

[Asaf Romano (gone)]

Bug is all/all.

(And for me (using os x)) I didn't find even one form that works in last nightlies)

Comment 18

[Brian Ryner (not reading)]

Attachment: patch

I think this is the patch we want for this and bug 242709.  It passes all of
the testcases here and does not regress any of the DOMActivate tests.

Comment 19

[Brian Ryner (not reading)]

Attachment: diff -w of the above

Comment 20

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148620 [details] [diff] [review]
patch

Oh, heh. r=bzbarsky

Comment 21

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Does jst really need to look at this or can someone else sr it?

Comment 22

[Brendan Eich [:brendan]]

Comment on attachment 148620 [details] [diff] [review]
patch

sr=[e-mail].

/be

Comment 23

[Dan M]

*** Bug 242714 has been marked as a duplicate of this bug. ***

Comment 24

[Brian Ryner (not reading)]

checked in

Comment 25

[Robert Parenton]

Clearing blocking1.8a? as this has been fixed.

Comment 26

[Asaf Romano (gone)]

I tried the last build of firefox:
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040519
Firefox/0.8.0+

and it is still there
I can't send any form with MacFirefox build since 1may 

Comment 27

[Dan M]

Asaf: most likely you're seeing bug 244698. This too is fixed in (very) recent
builds.