242495 - Extension to type mapping broken on Linux

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Boris Zbarsky [:bzbarsky]]

This is a regression from bug 197166.  It looks like the data is never copied
from "cbuf" into "buf" in the loop in
nsOSHelperAppService::GetTypeAndDescriptionFromMimetypesFile -- as a result, we
only ever see the first line of the file.

I suppose the other loops should be checked too, just to make sure.

And of course OS/2 has the same issues.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Whoops, sorry. OS/2 is OK..

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 147581 [details] [diff] [review]
proposed fix

r=bzbarsky, I think.  Like I said in the other bug, using -p and more context
(-u6 or -u8) would make patches a _lot_ easier to review...

Comment 3

[David :Bienvenu]

fixed, thx, I'll try to remember the -p option.