242574 - Firefox URL request frequently open in existing window and not a new window

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Scott MacGregor]

Per a conversation with Ben and Brian.

When clicking on a URL in thunderbird, it always opens in an existing Firefox
window instead of a a new window. Probably an issue with how we are processing
the DDE request.

Comment 1

[Scott MacGregor]

When I walk through this in the debugger everything works OK! Incoming DDE
requests are opened in a new window. 

In the debugger we go through:

http://lxr.mozilla.org/seamonkey/source/toolkit/xre/nsNativeAppSupportWin.cpp#1506

the newWindow argument here always defaults to TRUE so links are opening in a
new window

However, when I run an optimized build we go back to the unexpected behavior of
always opening in the existing window. I see a code path where this could be the
case but I can't get it to happen in the debugger. There is another DDE call:
HandleDDENotification which always defaults to using an existing window:

http://lxr.mozilla.org/seamonkey/source/toolkit/xre/nsNativeAppSupportWin.cpp#1190

it explicitly says "open in existing window"

I'm not sure what dictates that routine from being called in place of
HandleRequest yet.

Comment 2

[Scott MacGregor]

this looks interesting:

http://texturizer.net/firefox/tips.html#beh_reuse

Comment 3

[Jesse Ruderman]

This is similar to bug 172962, except that bug 172962 is asking for a pref
rather than a sane default.

This is a duplicate of bug 229919.

Comment 4

[Jesse Ruderman]

*** Bug 229919 has been marked as a duplicate of this bug. ***

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Weird, this seems magically fixed. 

Comment 6

[mmortal03]

Nope, I don't think it is fixed yet.  I don't know where the magic came from for
you...