242677 - trunk crash while downloading mails [@ nsMsgSearchTerm::StripQuotedPrintable ]

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Adam Hauner]

I'm crashing/hanging with newer trunk builds while downloading mails from POP3.
I have filters and junk control enabled. Crash/hang occurs probably only on one
account, so server-specific header may be cause.

http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=37727
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=37724
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=2&type=iid&id=37722

nsMsgSearchTerm::StripQuotedPrintable
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgSearchTerm.cpp,
line 690]
nsMsgSearchTerm::MatchBody
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgSearchTerm.cpp,
line 810]
nsMsgSearchOfflineMail::ProcessSearchTerm
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp,
line 530]
nsMsgSearchOfflineMail::ConstructExpressionTree
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp,
line 436]
nsMsgSearchOfflineMail::MatchTerms
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp,
line 630]
nsMsgSearchOfflineMail::MatchTermsForFilter
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgLocalSearch.cpp,
line 356]
nsMsgFilter::MatchHdr
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgFilter.cpp,
line 464]
nsMsgFilterList::ApplyFiltersToHdr
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/search/src/nsMsgFilterList.cpp,
line 330]
nsParseNewMailState::ApplyFilters
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsParseMailbox.cpp,
line 1587]
nsParseNewMailState::PublishMsgHeader
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsParseMailbox.cpp,
line 1529]
nsPop3Sink::IncorporateComplete
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Sink.cpp,
line 551]
nsPop3Protocol::HandleLine
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp,
line 3118]
nsMsgLineBuffer::ConvertAndSendBuffer
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/util/nsMsgLineBuffer.cpp,
line 237]
nsMsgLineBuffer::BufferInput
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/util/nsMsgLineBuffer.cpp,
line 210]
nsPop3Protocol::RetrResponse
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp,
line 2933]
nsPop3Protocol::ProcessProtocolState
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/local/src/nsPop3Protocol.cpp,
line 3515]
nsMsgProtocol::OnDataAvailable
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/mailnews/base/util/nsMsgProtocol.cpp,
line 326]
nsInputStreamPump::OnStateTransfer
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/netwerk/base/src/nsInputStreamPump.cpp,
line 437]
nsInputStreamPump::OnInputStreamReady
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/netwerk/base/src/nsInputStreamPump.cpp,
line 338]
nsInputStreamReadyEvent::EventHandler
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/io/nsStreamUtils.cpp,
line 119]
PL_HandleEvent
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c,
line 693]
PL_ProcessPendingEvents
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c,
line 631]
_md_EventReceiverProc
[c:/builds/tinderbox/MozillaTrunk/WINNT_5.0_Clobber/mozilla/xpcom/threads/plevent.c,
line 1434]

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[David :Bienvenu]

fixed on branch.

Comment 3

[Adam Hauner]

David, was this fixed also for Mozilla 1.7 branch? I had crash with 1.7.3
(TB2854618H), so if your patch didn't find way to 1.7 branch, I would like to
ask you for 1.7.6 patch. Fix looks trivial.

Comment 4

[Adam Hauner]

I was able reproduce this crash with 1.7.5/W2k (-> TB2854721M), so bug is not
fixed on branch. Could I ask for fix?

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 147784 [details] [diff] [review]
proposed fix

a=mkaply for 1.7.6

Comment 6

[timeless]

*** Bug 260584 has been marked as a duplicate of this bug. ***

Comment 7

[Jay Patel [:jay]]

verified fixed per talkback data:
http://talkback-public.mozilla.org/talkback/fastfind.jsp?search=1&searchby=stacksig&match=contains&searchfor=nsMsgSearchTerm%3A%3AStripQuotedPrintable&vendor=All&product=All&platform=All&buildid=&sdate=&stime=&edate=&etime=&sortby=bbid