242712 - '-moz-resizer' is unused and can probably die

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

http://lxr.mozilla.org/mozilla/search?string=-moz-resizer
http://lxr.mozilla.org/mozilla/search?string=MozResizer

Resizers now seem to be done with with <xul:resizer/> and '-moz-appearance:
resizer' so this can go I think.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Looks like I forgot to save nsStyleConsts.h before creating the diff.  The
following should also be added:

--- layout/base/public/nsStyleConsts.h  18 Apr 2004 14:30:22 -0000      3.75
+++ layout/base/public/nsStyleConsts.h  5 May 2004 19:25:11 -0000
@@ -67,13 +67,6 @@
 // key-equivalent
 #define NS_STYLE_KEY_EQUIVALENT_NONE      0
  
-// resizer
-#define NS_STYLE_RESIZER_NONE         0x00
-#define NS_STYLE_RESIZER_HORIZONTAL   0x01  // bits
-#define NS_STYLE_RESIZER_VERTICAL     0x02  // bits
-#define NS_STYLE_RESIZER_BOTH         0x03  // bits
-#define NS_STYLE_RESIZER_AUTO         0x04  // bits
-
 // user-focus
 #define NS_STYLE_USER_FOCUS_NONE            0
 #define NS_STYLE_USER_FOCUS_IGNORE          1

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Checked in 2004-05-05 14:37 PDT.

Comment 4

[R.K.Aa.]

during build i see thousands of warnings like:

../../../dist/include/content/nsCSSPropList.h:460: warning: invalid access to
   non-static data member `nsCSSPosition::mOffset' of NULL object
../../../dist/include/content/nsCSSPropList.h:460: warning: (perhaps the
   `offsetof' macro was used incorrectly)
../../../dist/include/content/nsCSSPropList.h:472: warning: invalid access to
   non-static data member `nsCSSPosition::mWidth' of NULL object
../../../dist/include/content/nsCSSPropList.h:472: warning: (perhaps the
   `offsetof' macro was used incorrectly)
../../../dist/include/content/nsCSSPropList.h:474: warning: invalid access to
   non-static data member `nsCSSPosition::mZIndex' of NULL object
../../../dist/include/content/nsCSSPropList.h:474: warning: (perhaps the
   `offsetof' macro was used incorrectly)
In file included from nsRuleNode.cpp:724:
../../../dist/include/content/nsCSSPropList.h:454: warning: invalid access to
   non-static data member `nsCSSTable::mLayout' of NULL object
../../../dist/include/content/nsCSSPropList.h:454: warning: (perhaps the

etc
same for other files like nsStyleStructList.h
are these known and harmless?

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

rkaa, those are known and have been around forever.  see the clobber
tinderboxes' logs.