242790 - [REGRESSION] Tabbing skips sub documents, GetSubDocumentFor() broken

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Aaron Leventhal]

Tabbing can no longer walk into sub documents. This means you can tab into
iframes, and you can't tab out of the address bar into a document.


I'm not sure when this broke, but I believe it could relate to
nsDocument::GetSubDocumentFor() being broken.

Comment 1

[Aaron Leventhal]

Attachment: Cannot tab into iframe.

Test case file isn't necessary to see that tabbing from address bar leads
nowhere.

Comment 2

[Aaron Leventhal]

This is breaking anything that uses GetSubDocumentFor(), including the
accessibility module and DOM inspector.

1.370 <[e-mail]> 2004-05-03 14:48
deCOMtaminate nsPIDOMWindow (bug 242111). r+sr=jst 

In nsDocumentViewer::SyncParentSubDocMap()
569                         nsCOMPtr<nsIDocShellTreeItem>
item(do_QueryInterface(mContainer));
570 bryner          1.370   nsCOMPtr<nsPIDOMWindow> pwin(do_QueryInterface(item));

This always makes pwin == nsnull because a docshell doesn't support the
nsPIDOMWindow interface.

The problem goes away if I change do_QueryInterface() back to do_GetInterface()

Comment 3

[Aaron Leventhal]

Attachment: QueryInterface -> GetInterface

I looked for other similar issues in the deCOMtamination patch for
nsPIDOMWindow, but could not find any.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 147808 [details] [diff] [review]
QueryInterface -> GetInterface

sr=jst

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381