242884 - Proxy config should require hostIP:port and/or error

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[benc]

Mozilla 1.7RC1.
STEPS:
Launch Linux Net Installer.
Enter a hostname -or a port (not both).

The incomplete information causes the installer to quit when installation is
started.

EXPECTED:
Either an error message in the dialog (hostIP -and- port are both required).
Or, at least, ignore the proxy info and not die on install.

Comment 1

[Andrew Schultz]

==> me

Comment 2

[Andrew Schultz]

there is actually a deeper problem here... the installer can't tell when you
delete a proxy field.  Instead of deleting the setting like the hostname, it
just sets the hostname to an empty (not NULL) string.

Comment 3

[Andrew Schultz]

Attachment: patch

I don't know if gtk_editable_get_chars can return NULL or not, so I've left the
check for that in.

Comment 4

[Andrew Schultz]

Attachment: patch

without extraneous stuff from other bugs...

Comment 5

[Andrew Schultz]

Attachment: patch

include silly LAST_ERR diffs.  filed bug 242908 to not have to mess with this
anymore.

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 147879 [details] [diff] [review]
patch

r=dveditz

Comment 7

[Andrew Schultz]

Attachment: patch merged to trunk

Comment 8

[Andrew Schultz]

fixed

Comment 9

[Andrew Schultz]

Attachment: patch to un-hose installer

I left out the installer.ini part of the patch

Comment 10

[Andrew Schultz]

Comment on attachment 157467 [details] [diff] [review]
patch to un-hose installer

this is in

Comment 11

[benc]

UPDATE:
I see the error message if I try to use an incomplete proxy config and hit "ok"

So the error dialog does appear when expected.

However, there is a problem, the "ok" button still saves the changes. If you hit
cancel (which would presumably discard your changes), and then press the proxy
button again, you will see that your incomplete proxy config is set in the dialog.

I've confirmed that the OK button is the cause (by independently unit testing
the cancel button's behavior).

If you try to install w/ this config, your install will die, and also send the
follow error to the terminal screen:

./mozilla-installer: line 70:  1261 Segmentation fault ./mozilla-installer-bin $@

Comment 12

[Andrew Schultz]

Attachment: patch

this patch
1. fixes what benc mentioned in previous comment
2. fixes leaks
3. preserves previous settings on cancel (instead of clearing them)

Comment 13

[Andrew Schultz]

Attachment: the right patch

Comment 14

[Daniel Veditz [:dveditz]]

Comment on attachment 159939 [details] [diff] [review]
the right patch

r=dveditz

Comment 15

[Andrew Schultz]

fixed