24296 - Access keys not in DTDs in many cases

Status: VERIFIED DUPLICATE of bug 40430

(Core :: Internationalization: Localization, defect, P3)

Description

[Robert Kaiser]

I posted a message about this in n.p.m.l10n which leaded me to report this:

Access keys are not in DTDs in many cases. Sometimes there aren't any at all but
many times they've been left in the XUL files.

<Tao Cheng's answer:> Yes, this is a localization roadblock that needs to to be
removed.

If Mozilla wants to set an accesskey "v" for the menu "Ansicht" ("View" in
en-US), it leaves the menu without any access key...

<Tao Cheng's answer:> The current plan is to leave accesskey alone;  Mozilla
will append the accesskey for English to the menu. For example,
"Ansicht" would become "Ansicht (Ctrl+V)".

<Yung-Fong Tang's answer:> I think this is a very common issue for Japanese /
Chinese / Korean in particulare. I remember Ray Chen (rchen) were
working w/ xp widget group (Chris Saari and David Hyatt) about this issue. What
is the update for this, ray ?

All of this is/was happening with M12 (win32) and is still happening using build
2000-01-18-08.

Comment 1

[Robert Kaiser]

Adding QA contact to [e-mail] as he wished in the thread.

Comment 2

[rchen]

Appending the accesskey character is in M13 with a minor bug which will be fixed 
in M14. I will look into the issue of access keys not in DTDs.

Comment 3

[Phil Peterson]

Laura, is this a beta1 stopper?

Comment 4

[rchen]

I don't think this is beta1 stopper. Kairo, can you point out which files?

Comment 5

[rchen]

Add Fergus and Chang. 

Fergus, Chang, we need to check if any access keys left in the XUL in each 
components. Contact and help the developers to move them to DTD files. Thanks.

Comment 6

[Robert Kaiser]

The following XULs contain hardcoded accesskeys in M13:
global/.../commonDialog.xul
editor/.../editor.xul (tableMenu...)
editor/.../TextEditorAppShell.xul (insertMenu...)
(messenger/.../messenger.xul contains accesskey="" what about that?)
(navigator/.../navigator.xul contains accesskey="" what about that?)
navigator/.../navigatorOverlay.xul (menu id="menu_View"!)
pref/.../pref-advanced.xul
pref/.../pref-appearance.xul
pref/.../pref-cache.xul
pref/.../pref-colors.xul
pref/.../pref-composer.xul
pref/.../pref-cookies.xul
pref/.../pref-debug.xul
pref/.../pref-dowload.xul
pref/.../pref-fonts.xul
(pref/.../pref-navigator.xul contains accesskey="" what about that?)
pref/.../pref-proxies.xul
pref/.../pref-search.xul
pref/.../pref-smart_browsing.xul
pref/.../pref-wallet.xul

That are all XUL files containing hardcoded accesskeys. (I didn't care if the
files need to have accesskeys at all - just did a serch and looked if they're
hardcoded or entities...)

Comment 7

[rickg]

It would be nice to have, but not essential. PDT-.

Comment 8

[rchen]

Change beta1 keyword to beta2 and Milestone to M15.

Comment 9

[Karl Ove Hufthammer]

This bug blocks bug #30456.

Comment 10

[Jim Roskind]

If (as it appears) this is not a blocker for the M15 stability checkpoint 
branch, please push this to M16 asap.
Thanks.

Comment 11

[msanz]

moving to m16

Comment 12

[msanz]

setting milestone to m17

Comment 13

[rchen]

reassign it to matt.

Comment 14

[leger]

Putting on [nsbeta2+] radar for beta2 fix.

Comment 15

[Fergus Sullivan]

I've created a new meta-bug (40430) to track this issue.  It points to all the 
bugs reported as a result of this one.

Accordingly I'm closing this bug as a dupe (even though it was the 
earlier of the two).

*** This bug has been marked as a duplicate of 40430 ***

Comment 16

[Stephen Walker]

verifying as a dupe