243064 - [FIX]Page content incorrectly replaced by script output

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Alan Smedley]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040505
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040508

The page should not be overwritten by the text from the counter, Previous
versions were OK

Reproducible: Always
Steps to Reproduce:
1. I unstalled the newest build on two different machnes running Windows XP with
all windows updates. 
2.  I reverted to the previous build that was working and did not see the problem
3.

Actual Results:  
The page is displayed but is overwritten by the text "834,714 (412 today)" which
will be a counter for the number of the current latest message on the forum and
the number of hits today.

Expected Results:  
The page should not be overwritten

Comment 1

[Boris Zbarsky [:bzbarsky]]

The behavior changed between 2004-05-06-08 and 2004-05-07-08 (and by the way, it
would help if you didn't put all the relevant information in the summary, it
can't be easily read....)

Checkins in that range:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-05-06+08%3A00%3A00&maxdate=2004-05-07+08%3A00%3A00&cvsroot=%2Fcvsroot

This is a regression from bug 242503.  This is why we all love the parser....

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Comment 3

[Alan Smedley]

(In reply to comment #1)
> The behavior changed between 2004-05-06-08 and 2004-05-07-08 (and by the way, it
> would help if you didn't put all the relevant information in the summary, it
> can't be easily read....)
> 
> Checkins in that range:
> 
>
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-05-06+08%3A00%3A00&maxdate=2004-05-07+08%3A00%3A00&cvsroot=%2Fcvsroot
> 
> This is a regression from bug 242503.  This is why we all love the parser....

I am new to this method of reporting with beta development and of logging bugs,
I will get to learn how it is done correctly.

How do I report correctly that I am still seeing the same bug in the new
(overnight) build in the output of the same page I refferred to in the original
message.  At this time I do not know how to use and test the patch attached to
the response.

Alan Smedley
  

Comment 4

[Boris Zbarsky [:bzbarsky]]

> I am new to this method of reporting with beta development and of logging
> bugs,

All good.  ;)  Thank you for finding this one, by the way!

> How do I report correctly that I am still seeing the same bug

You just say it in this bug like you did.  :)

The bug will keep appearing in builds until the patch is checked in (which will
happen after it has been reviewed).  At that point the bug will be marked fixed,
and then will need to be verified (that is, tested with a post-checkin build to
make sure that the patch fixed the bug).  That's the point at which it makes
sense to test this next.

To test the patch before then, you'd need to set up a build environment and
compile Mozilla, with the patch applied to it.  See
http://www.mozilla.org/build/win32.html for information on building Mozilla on
Windows.  It's probably quite a bit of work to set it up, to be truthful.... :(

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 148026 [details] [diff] [review]
Patch

r+sr=jst

Comment 6

[Boris Zbarsky [:bzbarsky]]

Checked in.  Alan, if you could test tomorrow's builds to verify, that would be
great.

Comment 7

[Alan Smedley]

The bug as reporteed appears to be fixed, Thank you.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Marking verified, per comment 7.  Thank you for retesting, Alan.