243130 - nsLocalMailFolder.cpp: Cannot assign const char* to char*

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Iain MacDonnell]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040507 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040507 Firefox/0.8.0+


Can't build mozilla or tunderbird from the trunk on Solaris with Sun Studio
compiler:

"nsLocalMailFolder.cpp", line 3032: Error: Cannot assign const char* to char*.
"nsLocalMailFolder.cpp", line 3055: Error: Cannot assign const char* to char*.
2 Error(s) detected.
gmake[5]: *** [nsLocalMailFolder.o] Error 2
gmake[5]: Leaving directory
`/export/stuff/mozilla/mozilla-20040508/mozilla/mailnews/local/src'


Reproducible: Always
Steps to Reproduce:
1.
2.
3.





Couldn't see an applicable component under mailnews for this ???

Comment 1

[Greg Onufer]

This is fallout from bienvenu's changes for bug 30057.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

so, this got added as part of:
1.456 <[e-mail]> 2004-05-08 08:35

But _why_ does strstr return a constant string??

Comment 3

[David :Bienvenu]

Attachment: proposed fix

this should fix it...

Comment 4

[timeless]

Comment on attachment 148070 [details] [diff] [review]
proposed fix

the reason it returns a constant string is that strstr can take a constant
string as input :).

#define STRSTR(haystack, needle) (haystack+(strstr(haystack,
needle)-haystack)).

The better question is why do some clibraries return a non const string?
the result is this compiling code:

#include <string.h>
#include <stdio.h>
const char readonly[]="read only\n"; const char crash[]="crash";
int main(void){
 char *crashonly; const char *crasher;
 crashonly=strstr(readonly,"r"); crasher=crash;
 do { *crashonly++=*crasher++; } while(*crasher);
 puts(readonly); return 0;
}

Comment 5

[Greg Onufer]

(In reply to comment #3)
> Created an attachment (id=148070)
> proposed fix
> 
> this should fix it...

Confirmed with mozilla trunk and thunderbird trunk builds.