243199 - Messages with =00 truncated

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Michal Cihar]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040114
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040114

When message contains NULL byte (=00 in quoted-printable), it gets truncated on
this byte.

Reproducible: Always
Steps to Reproduce:
1. Read message containing NULL byte.

Actual Results:  
Message is truncated.

Expected Results:  
See whole message.

Comment 1

[Mike Cowperthwaite]

Please save a sample email exhibiting this problem as a .EML file and attach it 
to this bug (using MIME type message/rfc822).

Comment 2

[Michal Cihar]

Attachment: Sample broken email

Here it comes. Removed some part of headers from original one.

Comment 3

[timeless]

Attachment: handle null the same way OE6 handles it

Comment 4

[Mike Cowperthwaite]

Well, if timeless is going to patch this, it had better be confirmed!  :)

Reproduced with 
  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a) Gecko/20040422

Comment 5

[David :Bienvenu]

Comment on attachment 148206 [details] [diff] [review]
handle null the same way OE6 handles it

elsewhere in mail, we replace null with a space - any reason not to do that
here?

Comment 6

[timeless]

OE6 doesn't use a space. That's all I know. I don't care at all.

I think I agree w/ OE, a null byte is not like a space character. If you're
going to pick something, use a zwjs or whatever.

Comment 7

[David :Bienvenu]

we've picked space every where else - let's just be consistent. The reason we
pick something is so that sizes won't change...

Comment 8

[timeless]

Attachment: handle null the way bienvenu says mozmail handles null

i'm not sure what you mean by space

/* We got =xy where "x" was hex and "y" was not, so
       treat that as a literal "=", x, and y.  (But, if
       this bogus token happened to occur over a buffer
       boundary, we can't do this, since we don't have
       space for it.  Oh well.	Screw it.) */

we clearly aren't very worried about certain kinds of spacing... (or efficiency
for that matter).

Comment 9

[timeless]

mozilla/mailnews/mime/src/mimeenc.cpp 	1.20

Comment 10

[WADA:World Anti-bad-Duping Agency]

*** Bug 291749 has been marked as a duplicate of this bug. ***

Comment 11

[WADA:World Anti-bad-Duping Agency]

Patch for this bug has perhaps produced issue of Bug 317009.

Comment 12

[Scott MacGregor]

Bug 308121 also has some information about this regression and its impact on PDF attachments.