Closed
Bug 243273
Opened 21 years ago
Closed 21 years ago
mingw gcc 3.4.0 build bustage
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.7final
People
(Reporter: cls, Assigned: cls)
Details
(Keywords: fixed1.7)
Attachments
(1 file)
|
4.54 KB,
patch
|
benjamin
:
review+
dbaron
:
superreview+
chofmann
:
approval1.7+
|
Details | Diff | Splinter Review |
gcc 3.4.0 is more c++ standards compliant than previous versions so win32
specific files will need to be fixed. The xp files should have already been
cleansed since we have gcc 3.4.0 builds working on linux.
This patch is fairly straightforward. It removes extraneous ;s and replaces
the HKEY_* macros with a local enum definition since the HKEY_* macros in the
mingw runtime include a cast to HKEY which is a void* and not an int as
expected.
Unfortunately, the build hangs after displaying the splash page. I'm still
working on tracking that down.
Comment on attachment 148217 [details] [diff] [review]
v1.0
So, it turns out that TestXPTCInvoke & winEmbed work fine. I'll try dropping
the optimization level later (from -O2) or do a debug build to see what else is
going on.
Attachment #148217 -
Flags: superreview?(dbaron)
Attachment #148217 -
Flags: review?(bsmedberg)
Attachment #148217 -
Flags: superreview?(dbaron) → superreview+
It's definitely some optimization issue. The default --enable-optimize (-O)
build works fine.
|
||
Updated•21 years ago
|
Attachment #148217 -
Flags: review?(bsmedberg) → review+
Attachment #148217 -
Flags: approval1.7?
|
||
Comment 4•21 years ago
|
||
Comment on attachment 148217 [details] [diff] [review]
v1.0
a=chofmann for 1.7
Attachment #148217 -
Flags: approval1.7? → approval1.7+
The patch has been checked in on the trunk & the 1.7 branch.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.7final
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•