243419 - gtkmozembed doesn't handle being moved between toplevels

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: 

GtkMozEmbed's realize handler connects callbacks to the toplevel's focus in/out
signals. However, it only does so on the first realize, and doesn't disconnect
on unrealize.

Now, when a GtkMozEmbed is moved to a different toplevel (like we do in Epiphany
by moving the tab containing the embed to another window by DND), the signal
handlers will be called from the wrong toplevel: from the old toplevel instead
of from the new toplevel.

Reproducible: Always
Steps to Reproduce:

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: proposed fix

Disconnect the focus in/out handlers from the toplevel on unrealize, and
connect them on every realize event.

Comment 2

[Tommi Komulainen]

*** Bug 242809 has been marked as a duplicate of this bug. ***

Comment 3

[Crispin Flowerday (not receiving bug mail)]

Comment on attachment 148313 [details] [diff] [review]
proposed fix

I am requesting approval for checking to 1.7. This patch fixes a nasty random
crash when using the gtk embedding widet (such as galeon and epiphany), see bug
242809 for that crash.

This is low risk, as it only touches the gtk embedding code, and will save a
lot of random crashes.

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 148313 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to 1.7

Comment 5

[Christopher Blizzard (:blizzard)]

Checked into the trunk.

Comment 6

[Christopher Blizzard (:blizzard)]

Checked into the 1.7 branch.