243476 - Remove accesskeys from listitems in pref-winhooks.xul

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Andreas Kunz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040501
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040501

http://lxr.mozilla.org/seamonkey/source/xpfe/components/prefwindow/resources/content/pref-winhooks.xul
(and the dtd) has accesskeys for all the listitems.
The problem: listitems have no accesskeys (or at least they do not do anything).
This was verified by selecting the first item of the list and then pressing
accesskeys for other items (with/without "Alt").
This was also confirmed by Neil and aaronl.

Reproducible: Always
Steps to Reproduce:




Those accesskeys are left from back when this was not a list, but several
checkboxes. http://bugzilla.mozilla.org/show_bug.cgi?id=70264#c6 added those
accesskeys.
They were converted to a tree and finally to a listbox, but the accesskeys were
never removed.

Comment 1

[Andreas Kunz]

Attachment: patch

Removes accesskeys from xul and dtd and improves indentation of four lines in
the dtd.

Comment 2

[Andreas Kunz]

Comment on attachment 148365 [details] [diff] [review]
patch

Requesting r= from Neil.

Comment 3

[[e-mail]]

Comment on attachment 148365 [details] [diff] [review]
patch

I think the protocol dtd entries were originally lined up with the show dialog
label.

Comment 4

[Andreas Kunz]

Comment on attachment 148365 [details] [diff] [review]
patch

...and now they are lined up with everything else.

Requesting sr= from alecf.

Comment 5

[Alec Flett]

Comment on attachment 148365 [details] [diff] [review]
patch

sr=alecf

Comment 6

[Andreas Kunz]

Checked in at 2004-05-14 03:36.