243483 - [FIX]realtime jprof has __restore_rt all over the profile results

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

<shaver> bz: it's part of glibc's signal handling code for realtime signals, IIRC
<shaver> are you using the rtc for profiling?
> yes
> I am
<shaver> mmmm, yes, yes
<shaver> I suspect there's an extra frame in place sometimes

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Skip over the __restore_rt frames

Comment 2

[Mike Shaver (:shaver emeritus)]

Comment on attachment 148376 [details] [diff] [review]
Skip over the __restore_rt frames

I think that's fine, given the general state of that code. r=shaver.

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 148376 [details] [diff] [review]
Skip over the __restore_rt frames

You could save the extra findSymbol call by moving the added code just inside
the |if(idx>=0)|, i.e., by comparing to externalSymbols[idx].name and then
decrementing and re-calling findSymbol if needed.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Do that

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 148396 [details] [diff] [review]
Do that

I was looking for something like that... ;)

Comment 6

[Mike Shaver (:shaver emeritus)]

Comment on attachment 148396 [details] [diff] [review]
Do that

Yes, indeed, even better. r=shaver.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed.