243580 - no license block in nss/cms/pk11util/pk11table.c

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

The NSS source file nss/cms/pk11util/pk11table.c has no license block 
or copyright notice.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: add license block and wrap long lines

This patch adds the missing license block.
It also wraps long lines of printed strings, and removes redundant spaces.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 148482 [details] [diff] [review]
add license block and wrap long lines

Bob, please review.

Comment 3

[Robert Relyea]

Comment on attachment 148482 [details] [diff] [review]
add license block and wrap long lines

On C_GenerateKeyPair and C_UnwrapKey where the command line wraps, I would
personally prefer either no ending \ or a space between the last word of the
line and the \. There is already an extra newline between the command and the
description, so there's no abiguity between the two.

r+ because it's not an issue that would prevent the checkin.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

P2 for 3.10
I will put a space before the trailing \ on the lines as requested.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

/cvsroot/mozilla/security/nss/cmd/pk11util/pk11table.c,v  <--  pk11table.c
new revision: 1.4; previous revision: 1.3