243750 - File am-advanced.xul is unused

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Stefan Borggraefe]

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Removes the file and associated cruft.

Comment 2

[Scott MacGregor]

Stefan, did this file ever have any real content?

I have a suspicion this file gets replaced by another file in the netscape
builds. If so, we probably need to keep it so we don't break that.

Comment 3

[Stefan Borggraefe]

(In reply to comment #2)
> Stefan, did this file ever have any real content?

Yes, its content was moved to other panes. Revision 1.5 is the last one with
something useful in it:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/prefs/resources/content/am-advanced.xul&rev=1.5

Since September 1999 (Revision 1.6) it had no content.

Also see

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/base/src&command=DIFF_FRAMESET&file=nsMsgAccountManagerDS.cpp&rev2=1.28&rev1=1.27

for the checkin that disabled this pane. Checkin comment "Remove the unused
Advanced panel".

> I have a suspicion this file gets replaced by another file in the netscape
> builds. If so, we probably need to keep it so we don't break that.

Hmm, I don't know much about Netscape, but the checkins that deactivated the
pane for Mozilla don't mention anything about this. Wouldn't there at least be a
warning comment somewhere so this isn't removed by accident?

Comment 4

[Scott MacGregor]

Comment on attachment 148607 [details] [diff] [review]
Patch

ok. Thanks for doing the detective work

Comment 5

[Stefan Borggraefe]

File be gone!

Fixed.