243820 - Relicensing libgtkxtbin

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Mary Hoetzel]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.4.1) Gecko/20031008
Build Identifier: 

The following files need to be relicensed:
widget/src/gtkxtbin/gtk2xtbin.c
widget/src/gtkxtbin/gtk2xtbin.h
widget/src/gtkxtbin/gtkxtbin.c
widget/src/gtkxtbin/gtkxtbin.h
widget/src/gtkxtbin/xembed.h

Not sure about this file. It doesn't have a license: 
widget/src/gtkxtbin/gtkxtbin.pkg

Reproducible: Always
Steps to Reproduce:

Comment 1

[Mary Hoetzel]

We would like to have this library relicensed in 1.7 for IBM's distribution of
Mozilla for AIX.

Comment 2

[Gervase Markham [:gerv]]

Attachment: Patch v.1

This patch relicenses the four files listed. As a comment-only patch, it gets
automatic super-review, so it merely needs review and approval from drivers.

Gerv

Comment 3

[Gervase Markham [:gerv]]

CCing Asa just in case drivers have stopped triaging nominated bugs.

Gerv

Comment 4

[Philip K. Warren]

Comment on attachment 148885 [details] [diff] [review]
Patch v.1

Just a few comments on this patch.

>Index: widget/src/gtkxtbin/gtkxtbin.c
>===================================================================
...
>+ * The Original Code is the Gtk2XtBin Widget Implementation.

This file is part of the GtkXtBin implementation (not Gtk2).

>+ * The Initial Developer of the Original Code is
>+ * Rusty Lynch.

Should this be "Intel Corporation" instead?

>Index: widget/src/gtkxtbin/gtkxtbin.h
>===================================================================
>RCS file: /cvsroot/mozilla/widget/src/gtkxtbin/gtkxtbin.h,v
>retrieving revision 1.4
>diff -5 -p -u -r1.4 gtkxtbin.h
>--- widget/src/gtkxtbin/gtkxtbin.h	15 Mar 2002 02:37:16 -0000	1.4
>+++ widget/src/gtkxtbin/gtkxtbin.h	19 May 2004 22:13:05 -0000
...
>+ * The Original Code is the Gtk2XtBin Widget Implementation.
>+ *
>+ * The Initial Developer of the Original Code is
>+ * Rusty Lynch.

See above.

>Index: widget/src/gtkxtbin/xembed.h
>===================================================================
...
>+ * The Initial Developer of the Original Code is
>+ * Rpbin Lu.

Should this be "Sun Microsystems, Inc." like the other files? If not this is a
typo (should be "Robin Lu").

Comment 5

[Gervase Markham [:gerv]]

Attachment: Patch v.2

Wow... for a five file, comment-only patch, that was impressively bad.

Try this.

Gerv

Comment 6

[Philip K. Warren]

Comment on attachment 148888 [details] [diff] [review]
Patch v.2

>Index: widget/src/gtkxtbin/gtkxtbin.h
>===================================================================
...
>+ * The Original Code is the Gtk2XtBin Widget Implementation.

Nit: I would change this to GtkXtBin like you did in the .c file. Everything
else looks good to me.

Comment 7

[Roland Mainz]

pkw wrote:
> >Index: widget/src/gtkxtbin/xembed.h
> >===================================================================
> ...
> >+ * The Initial Developer of the Original Code is
> >+ * Rpbin Lu.
>
> Should this be "Sun Microsystems, Inc." like the other files? If not this is a
> typo (should be "Robin Lu").

[Disclaimer: I am not speaking officially for Sun (I am not a lawyer :)]
Sun staff usually uses "1stname 2ndname <email>", e.g. "Robin Lu
<[e-mail]>", not the company name (AFAIK IBM is the only company which
enforces to use the company name instead of the names of the single developers).

Comment 8

[Philip K. Warren]

(In reply to comment #7)
> [Disclaimer: I am not speaking officially for Sun (I am not a lawyer :)]
> Sun staff usually uses "1stname 2ndname <email>", e.g. "Robin Lu
> <[e-mail]>", not the company name (AFAIK IBM is the only company which
> enforces to use the company name instead of the names of the single developers).

I see some of both in LXR:
http://lxr.mozilla.org/seamonkey/source/extensions/pref/system-pref/src/gconf/nsSystemPrefService.cpp#20
http://lxr.mozilla.org/seamonkey/source/intl/ctl/src/nsUnicodeToTIS620.h#17

Comment 9

[Robin Lu]

The license is ok for me. 

Comment 10

[Mike Kaply [:mkaply]]

Comment on attachment 148888 [details] [diff] [review]
Patch v.2

a=mkaply when the nits are straightened out

Comment 11

[Gervase Markham [:gerv]]

Fixed on 1.7 branch. I'm leaving this bug open until it gets fixed on the trunk
(which is currently frozen for 1.7alpha1.)

Checking in widget/src/gtkxtbin/gtk2xtbin.c;
/cvsroot/mozilla/widget/src/gtkxtbin/gtk2xtbin.c,v  <--  gtk2xtbin.c
new revision: 1.8.2.1; previous revision: 1.8
done
Checking in widget/src/gtkxtbin/gtk2xtbin.h;
/cvsroot/mozilla/widget/src/gtkxtbin/gtk2xtbin.h,v  <--  gtk2xtbin.h
new revision: 1.2.50.1; previous revision: 1.2
done
Checking in widget/src/gtkxtbin/gtkxtbin.c;
/cvsroot/mozilla/widget/src/gtkxtbin/gtkxtbin.c,v  <--  gtkxtbin.c
new revision: 1.14.80.1; previous revision: 1.14
done
Checking in widget/src/gtkxtbin/gtkxtbin.h;
/cvsroot/mozilla/widget/src/gtkxtbin/gtkxtbin.h,v  <--  gtkxtbin.h
new revision: 1.4.94.1; previous revision: 1.4
done
Checking in widget/src/gtkxtbin/xembed.h;
/cvsroot/mozilla/widget/src/gtkxtbin/xembed.h,v  <--  xembed.h
new revision: 1.1.68.1; previous revision: 1.1
done

Gerv

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The trunk isn't currently frozen.

Comment 13

[Gervase Markham [:gerv]]

I checked this in on 2004-05-24, but forgot to update the bug.

Gerv