24405 - Text gets cut off

Status: VERIFIED FIXED

(Core :: Printing: Output, defect, P3)

Description

[shrirang khanzode]

I used today's commercial build (2000011908) on Linux.
To recreate the problem, try the following steps:

1. Install and launch mozilla
2. go to the  "www.mozilla.org" site
3. Once the page loads, select the FILE|PRINT menu option.
4. Observe that the page prints with a big font and text gets cut off on the
   right side.

Comment 1

[shrirang khanzode]

Also seen on today's mac commercial build (2000011910). Windows
build(2000011908) prints this page fine.

Comment 2

[shrirang khanzode]

*** Bug 24730 has been marked as a duplicate of this bug. ***

Comment 3

[dcone (gone)]

Have a fix.. as soon as tree opens

Comment 4

[dcone (gone)]

Fixed on the Mac.
Syd.. can you replace the variable "mPixelScale" with "mCPixelScale" in the
file nsDeviceContextPS.cpp
mCPixelScale is defined in nsDeviceContext.h.
Delete the mPixelScale defined in nsDeviceContextPS.h.  This should fix the 
problem for Postscript output. I can do this while you are here if you want.

Comment 5

[dcone (gone)]

*** Bug 25830 has been marked as a duplicate of this bug. ***

Comment 6

[Syd Logan]

Changes have been applied. Back to dcone

Comment 7

[dcone (gone)]

Fixed.  The pixelscale was added to Linux printing.  Some of the page cutting 
off is due to a margin problem in another bug. (15522)

Comment 8

[shrirang khanzode]

Verified on Linux build(2000020308m14) and Mac build(2000020308m14). On mac, the 
text does not get cut off at all(gets cut off on linux). Marking verified.

Comment 9

[dcone (gone)]

On linux just modify the margins a tad and the text will be ok.
Maybee our defaults should have a wider right margin.

Comment 10

[shrirang khanzode]

Yes..I altered the right margin to 0.50 and it worked.I nitially the right 
margin is set to 0.0. Can we set it to .50 as default ?

Comment 11

[dcone (gone)]

Syd, can you set the default right margin to 0.5.
Thanks

Comment 12

[shrirang khanzode]

The default right margin is still 0.00 onlinux. As a result, the page still gets 
cut off on right side unless I set the margin to 0.50 manually.

Comment 13

[Syd Logan]

This will need to get reopened, and nominated for beta1 in the status whiteboard
if I am to possibly fix this.

Comment 14

[shrirang khanzode]

Reopening as per syd's comment

Comment 15

[dcone (gone)]

This is for you Syd.

Comment 16

[leger]

Putting on PDT- radar for beta.  Unless fix in hand.  If fix in hand, rickg says 
go for it.  But any amount of work left, bag for beta1.

Comment 17

[shrirang khanzode]

I see the default right margin set to .50 in today's commercial build on linux 
(2000022808m14). Text no longer appears cut.

Comment 18

[shrirang khanzode]

2000022808m15...is the correct build number.

Comment 19

[Syd Logan]

???

I haven't checked this in yet. Could you try removing (or copying somewhere)
your prefs.js file and start again? Probably the 0.5 you are seeing is coming
from your having changed the default and committing the pref.

Comment 20

[shrirang khanzode]

Syd, I hadn't deleted my registry. Sorry... It still appears as 0.00 after I 
created a new profile.

Comment 21

[Alex Musil]

Moving Syd's non-IM bugs to M20

Comment 22

[shrirang khanzode]

nominating beta2.Text gets cut off unless user manually sets the margin. Correct 
margin should be automatically set.

Comment 23

[Michael La Guardia]

Putting on nsbeta2+ radar.  Will become minus on 6/15.  Reassigning to Pavlov.
Pav, per Clayton, could you work with dcone to see if we can get this fixed?

Comment 24

[Joseph Elwell]

Youza, I will look at this 6/15. Easy fix, no reason to drop it.

Comment 25

[Jim Roskind]

Cleaning up statu whiteboard by marking beta2 minus (6/15 has passed)

Note to Elwell: This just means that Netscape engineers are too doomed with 
other tasks to get to this prior to beta2 (we have lots of more critical stuff 
that is sneeded).  If outsider contributors can fix the bug... we'd be pleased 
as heck to watch it happpen! 

Comment 26

[shrirang khanzode]

*** Bug 45980 has been marked as a duplicate of this bug. ***

Comment 27

[Tobias Burnus]

Can you first add nsbeta3? If nsbeta3-, then add helpme or so.

It shouldn't be too difficult to change the default value from 0 for bottom and
right to 0.5 (in what unit it is measured anyhow).

Since it works to store this value across session, this should be a trival task.

Goto Line 109 ff. in file:

./chrome/packages/widget-toolkit/global/content/printdialog.js
and change 

var print_margin_top = 500;
var print_margin_left = 500;
var print_margin_bottom = 0;
var print_margin_right = 0;

the 0 into 500 in the last lines.

Comment 28

[Tobias Burnus]

FIX, please review and apply.

--- ./chrome/packages/widget-toolkit/global/content/printdialog.js.old  Sun Sep
10 17:51:58 2000
+++ ./chrome/packages/widget-toolkit/global/content/printdialog.js      Sun Sep
10 17:52:12 2000
@@ -108,8 +108,8 @@
   var print_paper_size = 0;
   var print_margin_top = 500;
   var print_margin_left = 500;
-  var print_margin_bottom = 0;
-  var print_margin_right = 0;
+  var print_margin_bottom = 500;
+  var print_margin_right = 500;
   var print_command = default_command;
   var print_file = default_file;

Comment 29

[Tobias Burnus]

Wrong path. Please use: ./xpfe/global/resources/content/unix/printdialog.js
instead (source path, the other was the path in the final product)

Comment 30

[Tobias Burnus]

Attachment: Patch to change border-default value to 500

Comment 31

[Tobias Burnus]

Add via cc the owner of this component and ask him for review of the attached
patch.

Comment 32

[dcone (gone)]

This looks good to me.  The user can always change the margins also.. so it does 
not hurt anything.  It has my OK..

Comment 33

[Ben Goodger (use ben at mozilla dot org for email)]

a=ben. Sorry for the delay. 

Comment 34

[Tobias Burnus]

It would be nice if this could be suggested as rtm (and would get ++). Also it
would be nice if this could be checked in into the trunk.
(I cannot change the keywords and I cannot check in.)

Why this should be RTM? Well the fix is low risk and would remove this entry in
the release notes (from Netscape6PR3):
"(Linux only) Text is cut off on the right when printed. In the File menu,
choose Page Setup and change the rigth margin to .50 inches. Then try again."

Comment 35

[Andreas Franke (gone)]

Brendan, here seems to be a reviewed and approved "zero-risk" patch ready for
checkin. Can you find someone with CVS access to do that? Thanks.

Comment 36

[Andreas Franke (gone)]

Sorry, I must have confused 10/8 with 8/10 when looking at the approval date...

Comment 37

[Brendan Eich [:brendan]]

Ben or syd, can you check this in (if you haven't already)?  Thanks.

/be

Comment 38

[Syd Logan]

Reassigning to kevin for triage

Comment 39

[Kevin McCluskey (gone)]

Marking rtm-.  This problem is not serious enough to make the cut for the RTM
branch. However, we need to get it checked into the trunk.

Reassigning to Waqar. Waqar could you check this into the trunk? The patch has
been approved and reviewed.

Comment 40

[Kevin McCluskey (gone)]

Marking rtm-.

Comment 41

[Bradley Baetz]

dataloss - bits of the page go missing. Nominating for mozilla0.6 - there's an
approved patch, so could this go in? Changing the margin is not an immediately
obvious solution.

As an enhancement, could mozilla warn when the margins are set so small that
parts of the page will go missing?

Comment 42

[waqar]

Fix checked in.

Comment 43

[shrirang khanzode]

prints ok now on linux trunk 1212. VERIFIED