Closed
Bug 244062
Opened 21 years ago
Closed 21 years ago
Solaris build failure - "response" in HandleRemoteArgument() needs cast
Categories
(Core Graveyard :: X-remote, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mozbugs, Assigned: blizzard)
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040518 Firefox/0.8.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040518 Firefox/0.8.0+
Aviary builds fail on Solaris / Sun Studio:
(in toolkit/xre)
"nsAppRunner.cpp", line 1133: Error: Different types for "?:" (nsXPIDLCString
and const char*).
1 Error(s) detected.
gmake: *** [nsAppRunner.o] Error 1
Casting response to (const char *) allows it to compile...
Reproducible: Always
Steps to Reproduce:
1.
2.
3.
|
Reporter | |
Updated•21 years ago
|
OS: other → Solaris
Hardware: Other → Sun
Version: Trunk → Other Branch
|
|
||
Updated•21 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Reporter | |
Comment 1•21 years ago
|
||
Added a couple of suspects to CC :)
|
||
Comment 2•21 years ago
|
||
Make a patch, and I'll review it.
|
|
Reporter | |
Comment 3•21 years ago
|
||
First time I've submitted a patch, so apologies in advance if I haven't done it
correctly...
|
|
Reporter | |
Updated•21 years ago
|
Attachment #149057 -
Flags: review?(bsmedberg)
|
|
||
Comment 4•21 years ago
|
||
Comment on attachment 149057 [details] [diff] [review]
Proposed patch for Aviary branch (2004-05-21)
Thanks for the patch! This is a good attempt for the patch, but I think we
don't need a cast. I've committed a version that uses response.get() instead.
Attachment #149057 -
Flags: review?(bsmedberg)
|
|
Reporter | |
Comment 5•21 years ago
|
||
OK, that works too (just confirmed) - thanks! :)
|
|
||
Updated•21 years ago
|
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
|
||
Updated•21 years ago
|
Summary: Solars build failure - "response" in HandleRemoteArgument() needs cast → Solaris build failure - "response" in HandleRemoteArgument() needs cast
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•