244141 - Composition -> (default) Character Encoding should include Hebrew (Windows-1255)

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Prognathous]

Many people still prefer to send mail using 8-bit encodings rather than Unicode,
as these are more widely supported. However, Mozilla's current default encodings
menu only lists Hebrew/ISO-8859-8-i. This encoding is quite limiting compared to
Hebrew/Windows-1255 - it doesn't support Hebrew diacritics, nor does it support
important punctuation marks such as Maqaf, Geresh and Gershayim.

I suggest to include Windows-1255 in addition to the ISO encoding, rather than
to replace the latter.

I'm also ccing mscott, as this bug should also be fixed in Thunderbird.

Prog.

Comment 1

[Simon Montagu :smontagu]

Attachment: Add windows-1255 to intl.charsetmenu.mailedit

Comment 2

[Prognathous]

Whoaa... that was quick Simon, thanks! could you ask someone to review the
patch? there's still more than a week to squeeze this into 1.7

Prog.

Comment 3

[Jungshik Shin]

Comment on attachment 148939 [details] [diff] [review]
Add windows-1255 to intl.charsetmenu.mailedit

sorry for the delay (i've been out of country and still is) hope this is not
too late

Comment 4

[Prognathous]

Does this patch need an SR before an approval1.7 can be requested?

Prog.

Comment 5

[Asa Dotzler [:asa]]

not going to block the release for this but if you get a fully reviewed patch,
please request approval.

Comment 6

[Simon Montagu :smontagu]

Fix checked in to trunk.

Comment 7

[chris hofmann]

Comment on attachment 148939 [details] [diff] [review]
Add windows-1255 to intl.charsetmenu.mailedit

a=chofmann for 1.7

Comment 8

[Simon Montagu :smontagu]

Checked in to 1.7 branch.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems like you should patch toolkit/locale/intl.properties as well, no?

Comment 10

[Karen Huang]

Verified as fix on latest 1.7 branch 06-24 build.
Changing keywords from fixed1.7 to verified1.7.
Leave this bug status "as is" until this bug be verified on trunk again...

Comment 11

[Simon Montagu :smontagu]

Attachment: patch for toolkit

Comment 12

[Jungshik Shin]

Comment on attachment 153714 [details] [diff] [review]
patch for toolkit

r=jshin

Comment 13

[Simon Montagu :smontagu]

Attachment 153714 [details] [diff] is checked in to trunk.

Comment 14

[Asaf Romano (gone)]

Simon: have you also checked this into aviary branch?